Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: net/cookies/cookie_monster_perftest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/upload_bytes_element_reader_unittest.cc ('k') | net/curvecp/curvecp_server_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster_perftest.cc
diff --git a/net/cookies/cookie_monster_perftest.cc b/net/cookies/cookie_monster_perftest.cc
index 7e755f061f579c4468aca8e73c5f5d452ba2d96e..be55e4924f9bff88c55547d6492ce17f6d738206 100644
--- a/net/cookies/cookie_monster_perftest.cc
+++ b/net/cookies/cookie_monster_perftest.cc
@@ -149,7 +149,7 @@ TEST_F(CookieMonsterTest, TestAddCookiesOnSingleHost) {
for (std::vector<std::string>::const_iterator it = cookies.begin();
it != cookies.end(); ++it) {
- setCookieCallback.SetCookie(cm, kUrlGoogle, *it);
+ setCookieCallback.SetCookie(cm.get(), kUrlGoogle, *it);
}
timer.Done();
@@ -158,7 +158,7 @@ TEST_F(CookieMonsterTest, TestAddCookiesOnSingleHost) {
PerfTimeLogger timer2("Cookie_monster_query_single_host");
for (std::vector<std::string>::const_iterator it = cookies.begin();
it != cookies.end(); ++it) {
- getCookiesCallback.GetCookies(cm, kUrlGoogle);
+ getCookiesCallback.GetCookies(cm.get(), kUrlGoogle);
}
timer2.Done();
@@ -182,7 +182,7 @@ TEST_F(CookieMonsterTest, TestAddCookieOnManyHosts) {
PerfTimeLogger timer("Cookie_monster_add_many_hosts");
for (std::vector<GURL>::const_iterator it = gurls.begin();
it != gurls.end(); ++it) {
- setCookieCallback.SetCookie(cm, *it, cookie);
+ setCookieCallback.SetCookie(cm.get(), *it, cookie);
}
timer.Done();
@@ -191,7 +191,7 @@ TEST_F(CookieMonsterTest, TestAddCookieOnManyHosts) {
PerfTimeLogger timer2("Cookie_monster_query_many_hosts");
for (std::vector<GURL>::const_iterator it = gurls.begin();
it != gurls.end(); ++it) {
- getCookiesCallback.GetCookies(cm, *it);
+ getCookiesCallback.GetCookies(cm.get(), *it);
}
timer2.Done();
@@ -212,7 +212,7 @@ TEST_F(CookieMonsterTest, TestGetCookiesWithInfo) {
for (std::vector<GURL>::const_iterator it = gurls.begin();
it != gurls.end(); ++it) {
- setCookieCallback.SetCookie(cm, *it, kCookieLine);
+ setCookieCallback.SetCookie(cm.get(), *it, kCookieLine);
}
GetCookiesWithInfoCallback getCookiesCallback;
@@ -220,7 +220,7 @@ TEST_F(CookieMonsterTest, TestGetCookiesWithInfo) {
PerfTimeLogger timer("Cookie_monster_get_cookie_info");
for (std::vector<GURL>::const_iterator it = gurls.begin();
it != gurls.end(); ++it) {
- getCookiesCallback.GetCookiesWithInfo(cm, *it);
+ getCookiesCallback.GetCookiesWithInfo(cm.get(), *it);
}
timer.Done();
}
@@ -268,17 +268,17 @@ TEST_F(CookieMonsterTest, TestDomainTree) {
GURL gurl("https://" + *it + "/");
const std::string cookie = base::StringPrintf(domain_cookie_format_tree,
it->c_str());
- setCookieCallback.SetCookie(cm, gurl, cookie);
+ setCookieCallback.SetCookie(cm.get(), gurl, cookie);
}
EXPECT_EQ(31u, cm->GetAllCookies().size());
GURL probe_gurl("https://b.a.b.a.top.com/");
- std::string cookie_line = getCookiesCallback.GetCookies(cm, probe_gurl);
+ std::string cookie_line = getCookiesCallback.GetCookies(cm.get(), probe_gurl);
EXPECT_EQ(5, CountInString(cookie_line, '=')) << "Cookie line: " <<
cookie_line;
PerfTimeLogger timer("Cookie_monster_query_domain_tree");
for (int i = 0; i < kNumCookies; i++) {
- getCookiesCallback.GetCookies(cm, probe_gurl);
+ getCookiesCallback.GetCookies(cm.get(), probe_gurl);
}
timer.Done();
}
@@ -310,15 +310,15 @@ TEST_F(CookieMonsterTest, TestDomainLine) {
GURL gurl("https://" + *it + "/");
const std::string cookie = base::StringPrintf(domain_cookie_format_line,
i, it->c_str());
- setCookieCallback.SetCookie(cm, gurl, cookie);
+ setCookieCallback.SetCookie(cm.get(), gurl, cookie);
}
}
- cookie_line = getCookiesCallback.GetCookies(cm, probe_gurl);
+ cookie_line = getCookiesCallback.GetCookies(cm.get(), probe_gurl);
EXPECT_EQ(32, CountInString(cookie_line, '='));
PerfTimeLogger timer2("Cookie_monster_query_domain_line");
for (int i = 0; i < kNumCookies; i++) {
- getCookiesCallback.GetCookies(cm, probe_gurl);
+ getCookiesCallback.GetCookies(cm.get(), probe_gurl);
}
timer2.Done();
}
@@ -346,13 +346,13 @@ TEST_F(CookieMonsterTest, TestImport) {
store->SetLoadExpectation(true, initial_cookies);
- scoped_refptr<CookieMonster> cm(new CookieMonster(store, NULL));
+ scoped_refptr<CookieMonster> cm(new CookieMonster(store.get(), NULL));
// Import will happen on first access.
GURL gurl("www.google.com");
CookieOptions options;
PerfTimeLogger timer("Cookie_monster_import_from_store");
- getCookiesCallback.GetCookies(cm, gurl);
+ getCookiesCallback.GetCookies(cm.get(), gurl);
timer.Done();
// Just confirm keys were set as expected.
@@ -420,11 +420,11 @@ TEST_F(CookieMonsterTest, TestGCTimes) {
GURL gurl("http://google.com");
std::string cookie_line("z=3");
// Trigger the Garbage collection we're allowed.
- setCookieCallback.SetCookie(cm, gurl, cookie_line);
+ setCookieCallback.SetCookie(cm.get(), gurl, cookie_line);
PerfTimeLogger timer((std::string("GC_") + test_case.name).c_str());
for (int i = 0; i < kNumCookies; i++)
- setCookieCallback.SetCookie(cm, gurl, cookie_line);
+ setCookieCallback.SetCookie(cm.get(), gurl, cookie_line);
timer.Done();
}
}
« no previous file with comments | « net/base/upload_bytes_element_reader_unittest.cc ('k') | net/curvecp/curvecp_server_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698