Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 11242002: Change constant pool marker to be the unconditional, permanently undefined instruction. (Closed)

Created:
8 years, 2 months ago by JF
Modified:
8 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Change constant pool marker to be the unconditional, permanently undefined instruction. The previously-used instruction isn't guaranteed to always be undefined, and the encoding used was conditional (failing the condition on an undefined instruction is itself undefined and not guaranteed to fault!). I would have like to use a more clever encoding (see bug 2963), but we need the extra bits to encode the size of the constant pool. BUG=security R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +12 lines, -3 lines 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
JF
8 years, 2 months ago (2012-10-19 22:15:05 UTC) #1
ulan
LGTM, I will land it for you.
8 years, 2 months ago (2012-10-22 14:31:34 UTC) #2
ulan
8 years, 2 months ago (2012-10-22 14:32:34 UTC) #3
[+v8-dev]

Powered by Google App Engine
This is Rietveld 408576698