Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 11242002: Change constant pool marker to be the unconditional, permanently undefined instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/arm/constants-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2712 matching lines...) Expand 10 before | Expand all | Expand 10 after
2723 BlockConstPoolScope block_const_pool(this); 2723 BlockConstPoolScope block_const_pool(this);
2724 RecordComment("[ Constant Pool"); 2724 RecordComment("[ Constant Pool");
2725 RecordConstPool(size); 2725 RecordConstPool(size);
2726 2726
2727 // Emit jump over constant pool if necessary. 2727 // Emit jump over constant pool if necessary.
2728 Label after_pool; 2728 Label after_pool;
2729 if (require_jump) { 2729 if (require_jump) {
2730 b(&after_pool); 2730 b(&after_pool);
2731 } 2731 }
2732 2732
2733 // Put down constant pool marker "Undefined instruction" as specified by 2733 // Put down constant pool marker "Undefined instruction".
2734 // A5.6 (ARMv7) Instruction set encoding. 2734 emit(kConstantPoolMarker |
2735 emit(kConstantPoolMarker | num_pending_reloc_info_); 2735 EncodeConstantPoolLength(num_pending_reloc_info_));
2736 2736
2737 // Emit constant pool entries. 2737 // Emit constant pool entries.
2738 for (int i = 0; i < num_pending_reloc_info_; i++) { 2738 for (int i = 0; i < num_pending_reloc_info_; i++) {
2739 RelocInfo& rinfo = pending_reloc_info_[i]; 2739 RelocInfo& rinfo = pending_reloc_info_[i];
2740 ASSERT(rinfo.rmode() != RelocInfo::COMMENT && 2740 ASSERT(rinfo.rmode() != RelocInfo::COMMENT &&
2741 rinfo.rmode() != RelocInfo::POSITION && 2741 rinfo.rmode() != RelocInfo::POSITION &&
2742 rinfo.rmode() != RelocInfo::STATEMENT_POSITION && 2742 rinfo.rmode() != RelocInfo::STATEMENT_POSITION &&
2743 rinfo.rmode() != RelocInfo::CONST_POOL); 2743 rinfo.rmode() != RelocInfo::CONST_POOL);
2744 2744
2745 Instr instr = instr_at(rinfo.pc()); 2745 Instr instr = instr_at(rinfo.pc());
(...skipping 26 matching lines...) Expand all
2772 2772
2773 // Since a constant pool was just emitted, move the check offset forward by 2773 // Since a constant pool was just emitted, move the check offset forward by
2774 // the standard interval. 2774 // the standard interval.
2775 next_buffer_check_ = pc_offset() + kCheckPoolInterval; 2775 next_buffer_check_ = pc_offset() + kCheckPoolInterval;
2776 } 2776 }
2777 2777
2778 2778
2779 } } // namespace v8::internal 2779 } } // namespace v8::internal
2780 2780
2781 #endif // V8_TARGET_ARCH_ARM 2781 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/arm/constants-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698