src/arm/assembler-arm.cc - Issue 11242002: Change constant pool marker to be the unconditional, permanently undefined instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/assembler-arm.cc

Issue 11242002: Change constant pool marker to be the unconditional, permanently undefined instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/assembler-arm.cc

diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc

index 9be62a404bd2935864095744d1d4fa8a985a937b..80abafdefa348addcb241a14c0871dc207d488b5 100644

--- a/src/arm/assembler-arm.cc

+++ b/src/arm/assembler-arm.cc

@@ -2730,9 +2730,9 @@ void Assembler::CheckConstPool(bool force_emit, bool require_jump) {

b(&after_pool);

}

- // Put down constant pool marker "Undefined instruction" as specified by

- // A5.6 (ARMv7) Instruction set encoding.

- emit(kConstantPoolMarker | num_pending_reloc_info_);

+ // Put down constant pool marker "Undefined instruction".

+ emit(kConstantPoolMarker |

+ EncodeConstantPoolLength(num_pending_reloc_info_));

// Emit constant pool entries.

for (int i = 0; i < num_pending_reloc_info_; i++) {

« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/arm/constants-arm.h » ('j') | no next file with comments »