Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11175014: Use CheckSecurityForNode to filter out insecure calls (Closed)

Created:
8 years, 2 months ago by vsm
Modified:
8 years, 2 months ago
Reviewers:
podivilov, podivilov1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use CheckSecurityForNode to filter out insecure calls Testing note, I took out the special-cased lines under _removed_html_members, verified that crossframetest and innerframetest started breaking, and fixed with the more general code in this CL. Committed: https://code.google.com/p/dart/source/detail?r=13846

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -49 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 7 chunks +0 lines, -20 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 4 chunks +0 lines, -12 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 5 chunks +4 lines, -6 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 2 chunks +9 lines, -3 lines 0 comments Download
M lib/html/scripts/systemnative.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
8 years, 2 months ago (2012-10-19 20:46:25 UTC) #1
blois
lgtm https://chromiumcodereview.appspot.com/11175014/diff/1/lib/html/scripts/htmlrenamer.py File lib/html/scripts/htmlrenamer.py (right): https://chromiumcodereview.appspot.com/11175014/diff/1/lib/html/scripts/htmlrenamer.py#newcode268 lib/html/scripts/htmlrenamer.py:268: "LocalWindow.get:frames", There are a couple of filters for ...
8 years, 2 months ago (2012-10-19 21:06:35 UTC) #2
vsm
thanks, landing https://chromiumcodereview.appspot.com/11175014/diff/1/lib/html/scripts/htmlrenamer.py File lib/html/scripts/htmlrenamer.py (right): https://chromiumcodereview.appspot.com/11175014/diff/1/lib/html/scripts/htmlrenamer.py#newcode268 lib/html/scripts/htmlrenamer.py:268: "LocalWindow.get:frames", Thanks, I think I got everything ...
8 years, 2 months ago (2012-10-19 23:14:16 UTC) #3
podivilov1
8 years, 2 months ago (2012-10-22 08:03:13 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698