Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: lib/html/scripts/htmlrenamer.py

Issue 11175014: Use CheckSecurityForNode to filter out insecure calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/scripts/systemhtml.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/htmlrenamer.py
diff --git a/lib/html/scripts/htmlrenamer.py b/lib/html/scripts/htmlrenamer.py
index ee7892f19e7fe664566c58e3bf150edd7f883c95..efb93403b8ba0c21daba3f356f34b13c0701e4ef 100644
--- a/lib/html/scripts/htmlrenamer.py
+++ b/lib/html/scripts/htmlrenamer.py
@@ -211,7 +211,6 @@ _removed_html_members = set([
"Element.get:itemProp",
'Element.scrollIntoView',
'Element.get:classList',
- "EmbedElement.getSVGDocument",
"FormElement.get:elements",
"HTMLFrameElement.*",
"HTMLFrameSetElement.*",
@@ -219,10 +218,8 @@ _removed_html_members = set([
"HtmlElement.manifest",
"Document.version",
"Document.manifest",
-# "IFrameElement.getSVGDocument", #TODO(jacobr): should this be removed
"InputElement.dirName",
"HTMLIsIndexElement.*",
- "ObjectElement.getSVGDocument",
"HTMLOptionsCollection.*",
"HTMLPropertiesCollection.*",
"SelectElement.remove",
@@ -265,8 +262,6 @@ _removed_html_members = set([
"Node.lookupPrefix",
"Node.get:PROCESSING_INSTRUCTION_NODE",
'ShadowRoot.getElementsByTagNameNS',
- "IFrameElement.get:contentDocument",
- "LocalWindow.get:frameElement",
"LocalWindow.get:frames",
"LocalWindow.get:length",
"LocalWindow.webkitCancelRequestAnimationFrame",
@@ -286,7 +281,7 @@ class HtmlRenamer(object):
return html_interface_renames[interface.id]
return interface.id
- def RenameMember(self, interface_name, member, member_prefix=''):
+ def RenameMember(self, interface_name, member_node, member, member_prefix=''):
"""
Returns the name of the member in the HTML library or None if the member is
suppressed in the HTML library
@@ -296,6 +291,9 @@ class HtmlRenamer(object):
if self._FindMatch(interface, member, member_prefix, _removed_html_members):
return None
+ if 'CheckSecurityForNode' in member_node.ext_attrs:
+ return None
+
name = self._FindMatch(interface, member, member_prefix,
_renamed_html_members)
target_name = _renamed_html_members[name] if name else member
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/scripts/systemhtml.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698