Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1107363002: Merge M43: Fix crash on Enrollment screen. (Closed)

Created:
5 years, 8 months ago by Nikita (slow)
Modified:
5 years, 8 months ago
Reviewers:
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Merge M43: Fix crash on Enrollment screen. This is a sequel to crbug/470977, with a similar cause. This time, crash is induced by WizardController re-creation, so the old NetworkErrorModel pointers become invalid. Lesson learned: WizardController should NOT be the owner of an ErrorScreen instance. BUG=479666 Review URL: https://codereview.chromium.org/1098303002 Cr-Commit-Position: refs/heads/master@{#326317} (cherry picked from commit 97422a9583d83ea837f889a2e23adb157092f9ae) Committed: https://chromium.googlesource.com/chromium/src/+/58e5caba465ed043525f5b88e1b165e6aea349a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -38 lines) Patch
M chrome/browser/chromeos/login/screen_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nikita (slow)
5 years, 8 months ago (2015-04-28 11:52:30 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58e5caba465ed043525f5b88e1b165e6aea349a9.

Powered by Google App Engine
This is Rietveld 408576698