Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 1107363002: Merge M43: Fix crash on Enrollment screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2357
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/oobe_ui.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 AddScreenHandler(auto_enrollment_check_screen_handler); 283 AddScreenHandler(auto_enrollment_check_screen_handler);
284 284
285 HIDDetectionScreenHandler* hid_detection_screen_handler = 285 HIDDetectionScreenHandler* hid_detection_screen_handler =
286 new HIDDetectionScreenHandler(core_handler_); 286 new HIDDetectionScreenHandler(core_handler_);
287 hid_detection_view_ = hid_detection_screen_handler; 287 hid_detection_view_ = hid_detection_screen_handler;
288 AddScreenHandler(hid_detection_screen_handler); 288 AddScreenHandler(hid_detection_screen_handler);
289 289
290 error_screen_handler_ = new ErrorScreenHandler(); 290 error_screen_handler_ = new ErrorScreenHandler();
291 AddScreenHandler(error_screen_handler_); 291 AddScreenHandler(error_screen_handler_);
292 292
293 // Initialize ErrorScreen if it hasn't initialized so that NetworkErrorModel 293 error_screen_.reset(new ErrorScreen(nullptr, error_screen_handler_));
294 // is binded properly. 294 NetworkErrorModel* network_error_model = error_screen_.get();
295 NetworkErrorModel* network_error_model = nullptr;
296 if (WizardController::default_controller()) {
297 network_error_model = static_cast<NetworkErrorModel*>(
298 WizardController::default_controller()->GetScreen(
299 WizardController::kErrorScreenName));
300 CHECK(network_error_model);
301 } else {
302 error_screen_.reset(new ErrorScreen(nullptr, error_screen_handler_));
303 network_error_model = error_screen_.get();
304 }
305 295
306 EnrollmentScreenHandler* enrollment_screen_handler = 296 EnrollmentScreenHandler* enrollment_screen_handler =
307 new EnrollmentScreenHandler(network_state_informer_, network_error_model); 297 new EnrollmentScreenHandler(network_state_informer_, network_error_model);
308 enrollment_screen_actor_ = enrollment_screen_handler; 298 enrollment_screen_actor_ = enrollment_screen_handler;
309 AddScreenHandler(enrollment_screen_handler); 299 AddScreenHandler(enrollment_screen_handler);
310 300
311 TermsOfServiceScreenHandler* terms_of_service_screen_handler = 301 TermsOfServiceScreenHandler* terms_of_service_screen_handler =
312 new TermsOfServiceScreenHandler(core_handler_); 302 new TermsOfServiceScreenHandler(core_handler_);
313 terms_of_service_screen_actor_ = terms_of_service_screen_handler; 303 terms_of_service_screen_actor_ = terms_of_service_screen_handler;
314 AddScreenHandler(terms_of_service_screen_handler); 304 AddScreenHandler(terms_of_service_screen_handler);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 } 447 }
458 448
459 DeviceDisabledScreenActor* OobeUI::GetDeviceDisabledScreenActor() { 449 DeviceDisabledScreenActor* OobeUI::GetDeviceDisabledScreenActor() {
460 return device_disabled_screen_actor_; 450 return device_disabled_screen_actor_;
461 } 451 }
462 452
463 UserImageView* OobeUI::GetUserImageView() { 453 UserImageView* OobeUI::GetUserImageView() {
464 return user_image_view_; 454 return user_image_view_;
465 } 455 }
466 456
467 NetworkErrorView* OobeUI::GetNetworkErrorView() { 457 ErrorScreen* OobeUI::GetErrorScreen() {
468 return error_screen_handler_; 458 return error_screen_.get();
469 } 459 }
470 460
471 SupervisedUserCreationScreenHandler* 461 SupervisedUserCreationScreenHandler*
472 OobeUI::GetSupervisedUserCreationScreenActor() { 462 OobeUI::GetSupervisedUserCreationScreenActor() {
473 return supervised_user_creation_screen_actor_; 463 return supervised_user_creation_screen_actor_;
474 } 464 }
475 465
476 GaiaScreenHandler* OobeUI::GetGaiaScreenActor() { 466 GaiaScreenHandler* OobeUI::GetGaiaScreenActor() {
477 return gaia_screen_handler_; 467 return gaia_screen_handler_;
478 } 468 }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 506
517 bool keyboard_driven_oobe = 507 bool keyboard_driven_oobe =
518 system::InputDeviceSettings::Get()->ForceKeyboardDrivenUINavigation(); 508 system::InputDeviceSettings::Get()->ForceKeyboardDrivenUINavigation();
519 localized_strings->SetString("highlightStrength", 509 localized_strings->SetString("highlightStrength",
520 keyboard_driven_oobe ? "strong" : "normal"); 510 keyboard_driven_oobe ? "strong" : "normal");
521 511
522 bool new_kiosk_ui = KioskAppMenuHandler::EnableNewKioskUI(); 512 bool new_kiosk_ui = KioskAppMenuHandler::EnableNewKioskUI();
523 localized_strings->SetString("newKioskUI", new_kiosk_ui ? "on" : "off"); 513 localized_strings->SetString("newKioskUI", new_kiosk_ui ? "on" : "off");
524 } 514 }
525 515
526 scoped_ptr<ErrorScreen> OobeUI::GetErrorScreen() {
527 return error_screen_.Pass();
528 }
529
530 void OobeUI::InitializeScreenMaps() { 516 void OobeUI::InitializeScreenMaps() {
531 screen_names_.resize(SCREEN_UNKNOWN); 517 screen_names_.resize(SCREEN_UNKNOWN);
532 screen_names_[SCREEN_OOBE_HID_DETECTION] = kScreenOobeHIDDetection; 518 screen_names_[SCREEN_OOBE_HID_DETECTION] = kScreenOobeHIDDetection;
533 screen_names_[SCREEN_OOBE_NETWORK] = kScreenOobeNetwork; 519 screen_names_[SCREEN_OOBE_NETWORK] = kScreenOobeNetwork;
534 screen_names_[SCREEN_OOBE_EULA] = kScreenOobeEula; 520 screen_names_[SCREEN_OOBE_EULA] = kScreenOobeEula;
535 screen_names_[SCREEN_OOBE_UPDATE] = kScreenOobeUpdate; 521 screen_names_[SCREEN_OOBE_UPDATE] = kScreenOobeUpdate;
536 screen_names_[SCREEN_OOBE_ENROLLMENT] = kScreenOobeEnrollment; 522 screen_names_[SCREEN_OOBE_ENROLLMENT] = kScreenOobeEnrollment;
537 screen_names_[SCREEN_OOBE_ENABLE_DEBUGGING] = kScreenOobeEnableDebugging; 523 screen_names_[SCREEN_OOBE_ENABLE_DEBUGGING] = kScreenOobeEnableDebugging;
538 screen_names_[SCREEN_OOBE_RESET] = kScreenOobeReset; 524 screen_names_[SCREEN_OOBE_RESET] = kScreenOobeReset;
539 screen_names_[SCREEN_GAIA_SIGNIN] = kScreenGaiaSignin; 525 screen_names_[SCREEN_GAIA_SIGNIN] = kScreenGaiaSignin;
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 DCHECK(screen_ids_.count(screen)) 638 DCHECK(screen_ids_.count(screen))
653 << "Screen should be registered in InitializeScreenMaps()"; 639 << "Screen should be registered in InitializeScreenMaps()";
654 Screen new_screen = screen_ids_[screen]; 640 Screen new_screen = screen_ids_[screen];
655 FOR_EACH_OBSERVER(Observer, 641 FOR_EACH_OBSERVER(Observer,
656 observer_list_, 642 observer_list_,
657 OnCurrentScreenChanged(current_screen_, new_screen)); 643 OnCurrentScreenChanged(current_screen_, new_screen));
658 current_screen_ = new_screen; 644 current_screen_ = new_screen;
659 } 645 }
660 646
661 } // namespace chromeos 647 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/oobe_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698