Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11035024: ChromiumHTM instead of ChromiumHTML to respect progid restriction of 39 characters INCLUDING the NU… (Closed)

Created:
7 years, 1 month ago by gab
Modified:
7 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

ChromiumHTM instead of ChromiumHTML to respect progid restriction of 39 characters INCLUDING the NULL character... See http://crbug.com/153349 for more dtails. BUG=153349 TEST=Chromium can be set as default on Win8. Updating the old Chromium with this new progid makes it think it's not default, but it can be made default again and everything is good. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/installer/util/shell_util.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
I thought this through and decided it was ok to only update the progid. Here ...
7 years, 1 month ago (2012-10-04 02:32:50 UTC) #1
robertshield
lgtm
7 years, 1 month ago (2012-10-04 12:34:44 UTC) #2
grt (UTC plus 2)
lgtm
7 years, 1 month ago (2012-10-04 15:04:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11035024/1
7 years, 1 month ago (2012-10-04 15:29:47 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2012-10-04 18:37:03 UTC) #5
Change committed as 160173

Powered by Google App Engine
This is Rietveld 408576698