Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5008)

Unified Diff: chrome/installer/util/shell_util.cc

Issue 11035024: ChromiumHTM instead of ChromiumHTML to respect progid restriction of 39 characters INCLUDING the NU… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index 113b4793ce0c1a6d38d992d3041d805df6c93dba..7a066f306375dafd828fca8fea80bf3fa2810078 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -958,7 +958,14 @@ const wchar_t* ShellUtil::kAppPathsRegistryPathName = L"Path";
const wchar_t* ShellUtil::kChromeHTMLProgId = L"ChromeHTML";
const wchar_t* ShellUtil::kChromeHTMLProgIdDesc = L"Chrome HTML Document";
#else
-const wchar_t* ShellUtil::kChromeHTMLProgId = L"ChromiumHTML";
+// This used to be "ChromiumHTML", but was forced to become "ChromiumHTM"
+// because of http://crbug.com/153349 as with the '.' and 26 characters suffix
+// added on user-level installs, the generated progid for Chromium was 39
+// characters long which, according to MSDN (
+// http://msdn.microsoft.com/library/aa911706.aspx), is the maximum length
+// for a progid. It was however determined through experimentation that the 39
+// character limit mentioned on MSDN includes the NULL character...
+const wchar_t* ShellUtil::kChromeHTMLProgId = L"ChromiumHTM";
const wchar_t* ShellUtil::kChromeHTMLProgIdDesc = L"Chromium HTML Document";
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698