Issue 11030004: Switch TabContentsSyncedTabDelegate to use WebContentsUserData.

Issue 11030004: Switch TabContentsSyncedTabDelegate to use WebContentsUserData. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)

Modified:
8 years, 2 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, creis+watch_chromium.org, akalin, Raghu Simha, ajwong+watch_chromium.org, haitaol1, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch TabContentsSyncedTabDelegate to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160258

Patch Set 7 : rebase, added TODO #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -59 lines)			Patch
M	chrome/browser/sync/glue/session_change_processor.cc	View	1 2 3 4 5 6	5 chunks	+12 lines, -17 lines	0 comments	Download
M	chrome/browser/sync/glue/synced_tab_delegate.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/glue/synced_window_delegate_android.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/sync/browser_synced_window_delegate.cc	View	1 2 3 4 5	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc	View	1 2 3 4 5 6	1 chunk	+20 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View	1 2 3	3 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM https://codereview.chromium.org/11030004/diff/11009/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc File chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc (right): https://codereview.chromium.org/11030004/diff/11009/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc#newcode36 chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc:36: // Switch to just the web contents call ...

8 years, 2 months ago (2012-10-04 18:33:20 UTC) #4

Avi (use Gerrit)

https://codereview.chromium.org/11030004/diff/11009/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc File chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc (right): https://codereview.chromium.org/11030004/diff/11009/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc#newcode36 chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc:36: // Switch to just the web contents call when ...

8 years, 2 months ago (2012-10-04 19:02:20 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11030004/2003

8 years, 2 months ago (2012-10-04 19:04:14 UTC) #6

Change committed as 160258

Expand Messages | Collapse Messages