Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents.cc

Issue 11030004: Switch TabContentsSyncedTabDelegate to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, added TODO Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/tab_contents.h" 5 #include "chrome/browser/ui/tab_contents/tab_contents.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "chrome/browser/autofill/autocomplete_history_manager.h" 9 #include "chrome/browser/autofill/autocomplete_history_manager.h"
10 #include "chrome/browser/autofill/autofill_external_delegate.h" 10 #include "chrome/browser/autofill/autofill_external_delegate.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 new PasswordManager(contents, password_manager_delegate_.get())); 147 new PasswordManager(contents, password_manager_delegate_.get()));
148 PepperBrokerObserver::CreateForWebContents(contents); 148 PepperBrokerObserver::CreateForWebContents(contents);
149 PluginObserver::CreateForWebContents(contents); 149 PluginObserver::CreateForWebContents(contents);
150 PrefsTabHelper::CreateForWebContents(contents); 150 PrefsTabHelper::CreateForWebContents(contents);
151 prerender::PrerenderTabHelper::CreateForWebContents(contents); 151 prerender::PrerenderTabHelper::CreateForWebContents(contents);
152 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(contents); 152 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(contents);
153 SearchEngineTabHelper::CreateForWebContents(contents); 153 SearchEngineTabHelper::CreateForWebContents(contents);
154 chrome::search::SearchTabHelper::CreateForWebContents(contents); 154 chrome::search::SearchTabHelper::CreateForWebContents(contents);
155 SnapshotTabHelper::CreateForWebContents(contents); 155 SnapshotTabHelper::CreateForWebContents(contents);
156 SSLTabHelper::CreateForWebContents(contents); 156 SSLTabHelper::CreateForWebContents(contents);
157 synced_tab_delegate_.reset(new TabContentsSyncedTabDelegate(this)); 157 TabContentsSyncedTabDelegate::CreateForWebContents(contents);
158 TabSpecificContentSettings::CreateForWebContents(contents); 158 TabSpecificContentSettings::CreateForWebContents(contents);
159 TranslateTabHelper::CreateForWebContents(contents); 159 TranslateTabHelper::CreateForWebContents(contents);
160 ZoomController::CreateForWebContents(contents); 160 ZoomController::CreateForWebContents(contents);
161 161
162 #if defined(ENABLE_AUTOMATION) 162 #if defined(ENABLE_AUTOMATION)
163 AutomationTabHelper::CreateForWebContents(contents); 163 AutomationTabHelper::CreateForWebContents(contents);
164 #endif 164 #endif
165 165
166 #if defined(ENABLE_CAPTIVE_PORTAL_DETECTION) 166 #if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
167 captive_portal::CaptivePortalTabHelper::CreateForWebContents(contents); 167 captive_portal::CaptivePortalTabHelper::CreateForWebContents(contents);
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 241
242 //////////////////////////////////////////////////////////////////////////////// 242 ////////////////////////////////////////////////////////////////////////////////
243 // WebContentsObserver overrides 243 // WebContentsObserver overrides
244 244
245 void TabContents::WebContentsDestroyed(WebContents* tab) { 245 void TabContents::WebContentsDestroyed(WebContents* tab) {
246 // Destruction of the WebContents should only be done by us from our 246 // Destruction of the WebContents should only be done by us from our
247 // destructor. Otherwise it's very likely we (or one of the helpers we own) 247 // destructor. Otherwise it's very likely we (or one of the helpers we own)
248 // will attempt to access the WebContents and we'll crash. 248 // will attempt to access the WebContents and we'll crash.
249 DCHECK(in_destructor_); 249 DCHECK(in_destructor_);
250 } 250 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698