Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 11028094: [android_webview] Use AwContents loadUrl method instead of ContentViewCore. (Closed)

Created:
8 years, 2 months ago by mkosiba (inactive)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, benm (inactive)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[android_webview] Use AwContents loadUrl method instead of ContentViewCore. This introduces a loadUrl method on AwContents and modifies all of our test code to use that method instead of the on ContentViewCore. BUG=154558 Java-only change, ran through android FYI. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161113

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -500 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewLoadUrlTest.java View 6 chunks +17 lines, -14 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 1 2 8 chunks +25 lines, -25 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 6 chunks +9 lines, -12 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 2 85 chunks +265 lines, -245 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java View 1 25 chunks +70 lines, -58 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClearHistoryTest.java View 2 chunks +6 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientAddMessageToConsoleTest.java View 8 chunks +12 lines, -11 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 6 chunks +9 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java View 7 chunks +10 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java View 4 chunks +8 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewZoomTest.java View 7 chunks +18 lines, -14 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 6 chunks +14 lines, -13 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java View 5 chunks +9 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 12 chunks +25 lines, -21 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java View 7 chunks +24 lines, -22 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java View 2 chunks +6 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 6 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mkosiba (inactive)
PTAL
8 years, 2 months ago (2012-10-09 17:19:16 UTC) #1
joth
lgtm.
8 years, 2 months ago (2012-10-09 18:44:05 UTC) #2
benm (inactive)
lgtm
8 years, 2 months ago (2012-10-09 19:33:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11028094/1
8 years, 2 months ago (2012-10-09 20:47:20 UTC) #4
commit-bot: I haz the power
Change committed as 160959
8 years, 2 months ago (2012-10-09 22:41:51 UTC) #5
mkosiba (inactive)
change was reverted... committing one more time
8 years, 2 months ago (2012-10-10 09:16:20 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 10:19:57 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698