Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

Issue 11028094: [android_webview] Use AwContents loadUrl method instead of ContentViewCore. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase yet again Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
index 44b5b12662a0cf89775e0f313e2a15288f8cddae..9f911f7a220201ae28f4f3784065acc8d7fe089a 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
@@ -74,11 +74,11 @@ public class AndroidWebViewTestBase
}
}
- protected void enableJavaScriptOnUiThread(final ContentViewCore contentViewCore) {
+ protected void enableJavaScriptOnUiThread(final AwContents awContents) {
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
- contentViewCore.getContentSettings().setJavaScriptEnabled(true);
+ awContents.getContentViewCore().getContentSettings().setJavaScriptEnabled(true);
}
});
}
@@ -86,22 +86,22 @@ public class AndroidWebViewTestBase
/**
* Loads url on the UI thread and blocks until onPageFinished is called.
*/
- protected void loadUrlSync(final ContentViewCore contentViewCore,
+ protected void loadUrlSync(final AwContents awContents,
CallbackHelper onPageFinishedHelper,
final String url) throws Throwable {
int currentCallCount = onPageFinishedHelper.getCallCount();
- loadUrlAsync(contentViewCore, url);
+ loadUrlAsync(awContents, url);
onPageFinishedHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_SECONDS,
TimeUnit.SECONDS);
}
- protected void loadUrlSyncAndExpectError(final ContentViewCore contentViewCore,
+ protected void loadUrlSyncAndExpectError(final AwContents awContents,
CallbackHelper onPageFinishedHelper,
CallbackHelper onReceivedErrorHelper,
final String url) throws Throwable {
int onErrorCallCount = onReceivedErrorHelper.getCallCount();
int onFinishedCallCount = onPageFinishedHelper.getCallCount();
- loadUrlAsync(contentViewCore, url);
+ loadUrlAsync(awContents, url);
onReceivedErrorHelper.waitForCallback(onErrorCallCount, 1, WAIT_TIMEOUT_SECONDS,
TimeUnit.SECONDS);
onPageFinishedHelper.waitForCallback(onFinishedCallCount, 1, WAIT_TIMEOUT_SECONDS,
@@ -111,12 +111,12 @@ public class AndroidWebViewTestBase
/**
* Loads url on the UI thread but does not block.
*/
- protected void loadUrlAsync(final ContentViewCore contentViewCore,
+ protected void loadUrlAsync(final AwContents awContents,
final String url) throws Throwable {
runTestOnUiThread(new Runnable() {
@Override
public void run() {
- contentViewCore.loadUrl(new LoadUrlParams(url));
+ awContents.getContentViewCore().loadUrl(new LoadUrlParams(url));
}
});
}
@@ -124,12 +124,12 @@ public class AndroidWebViewTestBase
/**
* Loads data on the UI thread and blocks until onPageFinished is called.
*/
- protected void loadDataSync(final ContentViewCore contentViewCore,
+ protected void loadDataSync(final AwContents awContents,
CallbackHelper onPageFinishedHelper,
final String data, final String mimeType,
final boolean isBase64Encoded) throws Throwable {
int currentCallCount = onPageFinishedHelper.getCallCount();
- loadDataAsync(contentViewCore, data, mimeType, isBase64Encoded);
+ loadDataAsync(awContents, data, mimeType, isBase64Encoded);
onPageFinishedHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_SECONDS,
TimeUnit.SECONDS);
}
@@ -137,32 +137,32 @@ public class AndroidWebViewTestBase
/**
* Loads data on the UI thread but does not block.
*/
- protected void loadDataAsync(final ContentViewCore contentViewCore, final String data,
+ protected void loadDataAsync(final AwContents awContents, final String data,
final String mimeType, final boolean isBase64Encoded)
throws Throwable {
runTestOnUiThread(new Runnable() {
@Override
public void run() {
- contentViewCore.loadUrl(LoadUrlParams.createLoadDataParams(
+ awContents.loadUrl(LoadUrlParams.createLoadDataParams(
data, mimeType, isBase64Encoded));
}
});
}
protected AwTestContainerView createAwTestContainerView(final boolean incognito,
- final AwContentsClient contentsClient) {
+ final AwContentsClient awContentsClient) {
return createAwTestContainerView(incognito, new AwTestContainerView(getActivity()),
- contentsClient);
+ awContentsClient);
}
protected AwTestContainerView createAwTestContainerView(final boolean incognito,
final AwTestContainerView testContainerView,
- final AwContentsClient contentsClient) {
+ final AwContentsClient awContentsClient) {
ContentViewCore contentViewCore = new ContentViewCore(
getActivity(), ContentViewCore.PERSONALITY_VIEW);
testContainerView.initialize(contentViewCore,
new AwContents(testContainerView, testContainerView.getInternalAccessDelegate(),
- contentViewCore, contentsClient, new ActivityNativeWindow(getActivity()),
+ contentViewCore, awContentsClient, new ActivityNativeWindow(getActivity()),
incognito, false));
getActivity().addView(testContainerView);
return testContainerView;
@@ -188,31 +188,31 @@ public class AndroidWebViewTestBase
return testContainerView.get();
}
- protected void destroyAwContentsOnMainSync(final AwContents contents) {
- if (contents == null) return;
+ protected void destroyAwContentsOnMainSync(final AwContents awContents) {
+ if (awContents == null) return;
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
- contents.destroy();
+ awContents.destroy();
}
});
}
- protected String getTitleOnUiThread(final ContentViewCore contentViewCore) throws Throwable {
+ protected String getTitleOnUiThread(final AwContents awContents) throws Throwable {
return runTestOnUiThreadAndGetResult(new Callable<String>() {
@Override
public String call() throws Exception {
- return contentViewCore.getTitle();
+ return awContents.getContentViewCore().getTitle();
}
});
}
protected ContentSettings getContentSettingsOnUiThread(
- final ContentViewCore contentViewCore) throws Throwable {
+ final AwContents awContents) throws Throwable {
return runTestOnUiThreadAndGetResult(new Callable<ContentSettings>() {
@Override
public ContentSettings call() throws Exception {
- return contentViewCore.getContentSettings();
+ return awContents.getContentViewCore().getContentSettings();
}
});
}
@@ -231,7 +231,7 @@ public class AndroidWebViewTestBase
* Executes the given snippet of JavaScript code within the given ContentView. Returns the
* result of its execution in JSON format.
*/
- protected String executeJavaScriptAndWaitForResult(final ContentViewCore core,
+ protected String executeJavaScriptAndWaitForResult(final AwContents awContents,
TestAwContentsClient viewClient, final String code) throws Throwable {
final AtomicInteger requestId = new AtomicInteger();
TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper
@@ -240,7 +240,7 @@ public class AndroidWebViewTestBase
runTestOnUiThread(new Runnable() {
@Override
public void run() {
- requestId.set(core.evaluateJavaScript(code));
+ requestId.set(awContents.getContentViewCore().evaluateJavaScript(code));
}
});
onEvaluateJavaScriptResultHelper.waitForCallback(currentCallCount);

Powered by Google App Engine
This is Rietveld 408576698