android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java - Issue 11028094: [android_webview] Use AwContents loadUrl method instead of ContentViewCore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java

Issue 11028094: [android_webview] Use AwContents loadUrl method instead of ContentViewCore. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rebase yet again Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java

index e2e289dece1ceead38ff7bce3eb129485a6ab27e..786b9ed4b091f948d91027c8209d412025cb1212 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java

@@ -9,20 +9,19 @@ import android.test.suitebuilder.annotation.SmallTest;

import java.util.regex.Matcher;

import java.util.regex.Pattern;

+import org.chromium.android_webview.AwContents;

import org.chromium.base.test.util.Feature;

-import org.chromium.content.browser.ContentViewCore;

public class UserAgentTest extends AndroidWebViewTestBase {

private TestAwContentsClient mContentsClient;

- private ContentViewCore mContentViewCore;

+ private AwContents mAwContents;

@Override

public void setUp() throws Exception {

super.setUp();

mContentsClient = new TestAwContentsClient();

- mContentViewCore =

- createAwTestContainerViewOnMainSync(mContentsClient).getContentViewCore();

+ mAwContents = createAwTestContainerViewOnMainSync(mContentsClient).getAwContents();

}

/**

@@ -32,16 +31,16 @@ public class UserAgentTest extends AndroidWebViewTestBase {

@SmallTest

@Feature({"Android-WebView"})

public void testNoExtraSpaceBeforeBuildName() throws Throwable {

- getContentSettingsOnUiThread(mContentViewCore).setJavaScriptEnabled(true);

+ getContentSettingsOnUiThread(mAwContents).setJavaScriptEnabled(true);

loadDataSync(

- mContentViewCore,

+ mAwContents,

mContentsClient.getOnPageFinishedHelper(),

// Spaces are replaced with underscores to avoid consecutive spaces compression.

"<html>" +

"<body onload='document.title=navigator.userAgent.replace(/ /g, \"_\")'></body>" +

"</html>",

"text/html", false);

- final String ua = getTitleOnUiThread(mContentViewCore);

+ final String ua = getTitleOnUiThread(mAwContents);

Matcher matcher = Pattern.compile("Android_[^;]+;_[^_]").matcher(ua);

assertTrue(matcher.find());

}