Don't show the titlebar in fullscreen windows on ash.

Don't show the titlebar in fullscreen windows on ash.

R=ben@chromium.org
BUG=153475
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160708

[Ben Goodger (Google), 2012-10-08 18:20:00]

https://codereview.chromium.org/11028074/diff/1/ash/wm/custom_frame_view_ash.cc
File ash/wm/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/11028074/diff/1/ash/wm/custom_frame_view_ash....
ash/wm/custom_frame_view_ash.cc:128: if (frame_->IsFullscreen())
Would your change to NonClientTopBorderHeight() result in this area not being
painted anyway? If so is it possible to just dcheck this?

[jeremya, 2012-10-08 18:25:16]

https://codereview.chromium.org/11028074/diff/1/ash/wm/custom_frame_view_ash.cc
File ash/wm/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/11028074/diff/1/ash/wm/custom_frame_view_ash....
ash/wm/custom_frame_view_ash.cc:128: if (frame_->IsFullscreen())
On 2012/10/08 18:20:00, Ben Goodger (Google) wrote:
> Would your change to NonClientTopBorderHeight() result in this area not being
> painted anyway? If so is it possible to just dcheck this?

OnPaint still seems to get called when NonClientTopBorderHeight returns 0.

[Ben Goodger (Google), 2012-10-08 18:26:48]

Does it paint anything useful?

[jeremya, 2012-10-08 18:30:40]

On 2012/10/08 18:26:48, Ben Goodger (Google) wrote:
> Does it paint anything useful?

I'm pretty sure it would just paint the normal header, but since the client
bounds are the size of the whole window, the web content covers it up.

[Ben Goodger (Google), 2012-10-08 18:31:07]

ic. lgtm.


On Mon, Oct 8, 2012 at 11:30 AM, <jeremya@chromium.org> wrote:

> On 2012/10/08 18:26:48, Ben Goodger (Google) wrote:
>
>> Does it paint anything useful?
>>
>
> I'm pretty sure it would just paint the normal header, but since the client
> bounds are the size of the whole window, the web content covers it up.
>
>
https://codereview.chromium.**org/11028074/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2012-10-08 19:34:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/11028074/1

[commit-bot: I haz the power, 2012-10-08 21:26:18]

Change committed as 160708