Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: ash/wm/custom_frame_view_ash.cc

Issue 11028074: Don't show the titlebar in fullscreen windows on ash. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/custom_frame_view_ash.cc
diff --git a/ash/wm/custom_frame_view_ash.cc b/ash/wm/custom_frame_view_ash.cc
index 77977f2f51c66ad62a351d33aab952e3d102e243..a7f7517a9b9a4b1dba6faa2864ef7ffde305932b 100644
--- a/ash/wm/custom_frame_view_ash.cc
+++ b/ash/wm/custom_frame_view_ash.cc
@@ -125,6 +125,9 @@ void CustomFrameViewAsh::Layout() {
}
void CustomFrameViewAsh::OnPaint(gfx::Canvas* canvas) {
+ if (frame_->IsFullscreen())
Ben Goodger (Google) 2012/10/08 18:20:00 Would your change to NonClientTopBorderHeight() re
jeremya 2012/10/08 18:25:16 OnPaint still seems to get called when NonClientTo
+ return;
+
bool paint_as_active = ShouldPaintAsActive();
int theme_image_id = paint_as_active ? IDR_AURA_WINDOW_HEADER_BASE_ACTIVE :
IDR_AURA_WINDOW_HEADER_BASE_INACTIVE;
@@ -171,6 +174,9 @@ void CustomFrameViewAsh::ButtonPressed(views::Button* sender,
// CustomFrameViewAsh, private:
int CustomFrameViewAsh::NonClientTopBorderHeight() const {
+ if (frame_->IsFullscreen())
+ return 0;
+
// Reserve enough space to see the buttons, including any offset from top and
// reserving space for the separator line.
return close_button_->bounds().bottom() +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698