Don't show the titlebar in fullscreen windows on ash.

ash/wm/custom_frame_view_ash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/custom_frame_view_ash.h"
 
 #include "ash/wm/frame_painter.h"
 #include "ash/wm/workspace/frame_maximize_button.h"
 #include "grit/ash_resources.h"
 #include "grit/ui_strings.h"  // Accessibility names
@@ skipping 107 matching lines @@
   return frame_->non_client_view()->GetWindowBoundsForClientBounds(
       bounds).size();
 }
 
 void CustomFrameViewAsh::Layout() {
   // Use the shorter maximized layout headers.
   frame_painter_->LayoutHeader(this, true);
 }
 
 void CustomFrameViewAsh::OnPaint(gfx::Canvas* canvas) {
+  if (frame_->IsFullscreen())

[Ben Goodger (Google), 2012/10/08 18:20:00]

Would your change to NonClientTopBorderHeight() result in this area not being
painted anyway? If so is it possible to just dcheck this?

[jeremya, 2012/10/08 18:25:16]

OnPaint still seems to get called when NonClientTopBorderHeight returns 0.

+    return;
+
   bool paint_as_active = ShouldPaintAsActive();
   int theme_image_id = paint_as_active ? IDR_AURA_WINDOW_HEADER_BASE_ACTIVE :
       IDR_AURA_WINDOW_HEADER_BASE_INACTIVE;
   frame_painter_->PaintHeader(
       this,
       canvas,
       paint_as_active ? FramePainter::ACTIVE : FramePainter::INACTIVE,
       theme_image_id,
       NULL);
   frame_painter_->PaintTitleBar(this, canvas, GetTitleFont());
@@ skipping 26 matching lines @@
     frame_->Close();
   }
   if (event.IsShiftDown())
     ui::LayerAnimator::set_slow_animation_mode(false);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // CustomFrameViewAsh, private:
 
 int CustomFrameViewAsh::NonClientTopBorderHeight() const {
+  if (frame_->IsFullscreen())
+    return 0;
+
   // Reserve enough space to see the buttons, including any offset from top and
   // reserving space for the separator line.
   return close_button_->bounds().bottom() +
       frame_painter_->HeaderContentSeparatorSize();
 }
 
 }  // namespace ash