[dart2dart] Make sure we collect element placeholders only for identifiers by ensuring

[dart2dart] Make sure we collect element placeholders only for identifiers by ensuring
that if TypeAnnotation's typeName is Send, make 2 placeholders instead of 1 - for prefix
and for the element itself.
This makes the whole approach cleaner. Later we can just rename all identifiers and
transform AST.

Based on https://chromiumcodereview.appspot.com/11034021/

Committed: https://code.google.com/p/dart/source/detail?r=13277

[Roman, 2012-10-04 15:03:40]

rebased

[Anton Muhin, 2012-10-04 15:34:37]

Looks cool

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:302:
makeNullPlaceholder(node.receiver);
is it okay if we use a name with a prefix from platform lib?

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:480:
makeNullPlaceholder(node.typeName.receiver);
ditto

[Roman, 2012-10-04 16:05:59]

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:302:
makeNullPlaceholder(node.receiver);
On 2012/10/04 15:34:37, Anton Muhin wrote:
> is it okay if we use a name with a prefix from platform lib?

We never use existing prefixes in the renamer anyway. For platform library
elements we just generate a string 'p.Map', for example.
But now I'm thinking that ideally we should probably record a prefix and in
renamer decide whether we want to keep that prefix or strip it completely. But
that would require refactoring of how we currently import things.

[Anton Muhin, 2012-10-04 16:07:14]

lgtm

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11026027/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:302:
makeNullPlaceholder(node.receiver);
Fair.

On 2012/10/04 16:05:59, Roman wrote:
> On 2012/10/04 15:34:37, Anton Muhin wrote:
> > is it okay if we use a name with a prefix from platform lib?
> 
> We never use existing prefixes in the renamer anyway. For platform library
> elements we just generate a string 'p.Map', for example.
> But now I'm thinking that ideally we should probably record a prefix and in
> renamer decide whether we want to keep that prefix or strip it completely. But
> that would require refactoring of how we currently import things.