[dart2dart] Don't go inside TypeAnnotation.typeName, otherwise in "new lib.A()" expression

[dart2dart] Don't go inside TypeAnnotation.typeName, otherwise in "lib.A" expression
"A" is added to member placeholders. We were lucky to not step on that because we add whole
TypeAnnotation's typeName to renamed nodes.

Committed: https://code.google.com/p/dart/source/detail?r=13235

[Roman, 2012-10-02 14:57:10]

This CL is a part of my idea to separate prefix renaming and making element
placeholders map from Identifiers only.

https://chromiumcodereview.appspot.com/11034021/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11034021/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:529:
visit(node.modifiers);
I know you don't like calling explicitly visit() for children, but it is cleaner
this way. As a side effect we don't rename constructors as member identifiers.

[Anton Muhin, 2012-10-04 12:26:47]

lgtm w/ nit about long lines addressed

https://chromiumcodereview.appspot.com/11034021/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11034021/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:479: //
Visit only type arguments, otherwise in case of lib.Class type annotation
nit: long line

[Roman, 2012-10-04 12:40:48]

https://chromiumcodereview.appspot.com/11034021/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11034021/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:479: //
Visit only type arguments, otherwise in case of lib.Class type annotation
On 2012/10/04 12:26:47, Anton Muhin wrote:
> nit: long line

Done.