Issue 10990064: Revert 156678 - Native messaging now uses the MessageService back-end.

Issue 10990064: Revert 156678 - Native messaging now uses the MessageService back-end. (Closed)

Created:
8 years, 2 months ago by Matt Perry

Modified:
8 years, 2 months ago

Reviewers:
eaugusti

CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. (try #2 after the last revert broke compile.) BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159210

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -1489 lines)			Patch
D	chrome/browser/extensions/api/messaging/extension_message_port.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/extension_message_port.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download
M	chrome/browser/extensions/api/messaging/message_service.h	View	7 chunks	+10 lines, -74 lines	0 comments	Download
M	chrome/browser/extensions/api/messaging/message_service.cc	View	16 chunks	+146 lines, -183 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_port.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_port.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_process_host.h	View	1 chunk	+0 lines, -178 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_process_host.cc	View	1 chunk	+0 lines, -223 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_process_host_posix.cc	View	1 chunk	+0 lines, -71 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc	View	1 chunk	+0 lines, -177 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_message_process_host_win.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_messaging_apitest_posix.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_process_launcher.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	chrome/browser/extensions/api/messaging/native_process_launcher_win.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	chrome/browser/extensions/extension_system.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/message_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.cc	View	2 chunks	+0 lines, -36 lines	0 comments	Download
M	chrome/browser/tab_contents/background_contents.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/extension.json	View	2 chunks	+0 lines, -62 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/renderer/extensions/extension_custom_bindings.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/extension_custom_bindings.cc	View	3 chunks	+0 lines, -34 lines	0 comments	Download
M	chrome/renderer/resources/extensions/extension_custom_bindings.js	View	5 chunks	+1 line, -43 lines	0 comments	Download
M	chrome/renderer/resources/extensions/miscellaneous_bindings.js	View	2 chunks	+2 lines, -4 lines	0 comments	Download