Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

Issue 10990064: Revert 156678 - Native messaging now uses the MessageService back-end. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
deleted file mode 100644
index e7cbce78e994558082581c446518a6cfebe990ff..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
+++ /dev/null
@@ -1,58 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
-
-#include "base/command_line.h"
-#include "base/eintr_wrapper.h"
-#include "base/file_util.h"
-#include "base/logging.h"
-#include "base/process_util.h"
-
-namespace extensions {
-
-bool NativeProcessLauncher::LaunchNativeProcess(
- const FilePath& path,
- base::ProcessHandle* native_process_handle,
- NativeMessageProcessHost::FileHandle* read_file,
- NativeMessageProcessHost::FileHandle* write_file) const {
- base::FileHandleMappingVector fd_map;
-
- int read_pipe_fds[2] = {0};
- if (HANDLE_EINTR(pipe(read_pipe_fds)) != 0) {
- LOG(ERROR) << "Bad read pipe";
- return false;
- }
- file_util::ScopedFD read_pipe_read_fd(&read_pipe_fds[0]);
- file_util::ScopedFD read_pipe_write_fd(&read_pipe_fds[1]);
- fd_map.push_back(std::make_pair(*read_pipe_write_fd, STDOUT_FILENO));
-
- int write_pipe_fds[2] = {0};
- if (HANDLE_EINTR(pipe(write_pipe_fds)) != 0) {
- LOG(ERROR) << "Bad write pipe";
- return false;
- }
- file_util::ScopedFD write_pipe_read_fd(&write_pipe_fds[0]);
- file_util::ScopedFD write_pipe_write_fd(&write_pipe_fds[1]);
- fd_map.push_back(std::make_pair(*write_pipe_read_fd, STDIN_FILENO));
-
- CommandLine line(path);
- base::LaunchOptions options;
- options.fds_to_remap = &fd_map;
- if (!base::LaunchProcess(line, options, native_process_handle)) {
- LOG(ERROR) << "Error launching process";
- return false;
- }
-
- // We will not be reading from the write pipe, nor writing from the read pipe.
- write_pipe_read_fd.reset();
- read_pipe_write_fd.reset();
-
- *read_file = *read_pipe_read_fd.release();
- *write_file = *write_pipe_write_fd.release();
-
- return true;
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698