Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/renderer/extensions/extension_custom_bindings.cc

Issue 10990064: Revert 156678 - Native messaging now uses the MessageService back-end. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_custom_bindings.cc
diff --git a/chrome/renderer/extensions/extension_custom_bindings.cc b/chrome/renderer/extensions/extension_custom_bindings.cc
index e3c5afc7b07789c6104bc2b0332f1776e5738971..685c18027cd0231c2f7360720c59148570f5e73c 100644
--- a/chrome/renderer/extensions/extension_custom_bindings.cc
+++ b/chrome/renderer/extensions/extension_custom_bindings.cc
@@ -15,7 +15,6 @@
#include "chrome/renderer/extensions/dispatcher.h"
#include "chrome/renderer/extensions/extension_helper.h"
#include "content/public/renderer/render_view.h"
-#include "content/public/renderer/v8_value_converter.h"
#include "grit/renderer_resources.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
@@ -32,7 +31,6 @@ ExtensionCustomBindings::ExtensionCustomBindings(Dispatcher* dispatcher)
: ChromeV8Extension(dispatcher) {
RouteStaticFunction("GetExtensionViews", &GetExtensionViews);
RouteStaticFunction("OpenChannelToExtension", &OpenChannelToExtension);
- RouteStaticFunction("OpenChannelToNativeApp", &OpenChannelToNativeApp);
}
// static
@@ -125,36 +123,4 @@ v8::Handle<v8::Value> ExtensionCustomBindings::OpenChannelToExtension(
return v8::Integer::New(port_id);
}
-// static
-v8::Handle<v8::Value> ExtensionCustomBindings::OpenChannelToNativeApp(
- const v8::Arguments& args) {
- // Get the current RenderView so that we can send a routed IPC message from
- // the correct source.
- content::RenderView* renderview = GetCurrentRenderView();
- if (!renderview)
- return v8::Undefined();
-
- // The Javascript code should validate/fill the arguments.
- CHECK(args.Length() >= 3 &&
- args[0]->IsString() &&
- args[1]->IsString() &&
- args[2]->IsString() &&
- args[3]->IsString());
-
- std::string extension_id = *v8::String::Utf8Value(args[0]->ToString());
- std::string native_app_name = *v8::String::Utf8Value(args[1]->ToString());
- std::string channel_name = *v8::String::Utf8Value(args[2]->ToString());
- std::string connect_message = *v8::String::Utf8Value(args[3]->ToString());
-
- int port_id = -1;
- renderview->Send(new ExtensionHostMsg_OpenChannelToNativeApp(
- renderview->GetRoutingID(),
- extension_id,
- native_app_name,
- channel_name,
- connect_message,
- &port_id));
- return v8::Integer::New(port_id);
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698