Add extra buckets to CrashExitCodes histogram for sandbox terminations

Add extra buckets to CrashExitCodes histogram for sandbox terminations.

BUG=152814
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159215

[jar (doing other things), 2012-09-27 22:38:56]

FYI: Kai will be landing the sparse histograms RSN. That will surely make this a
lot easier.

LGTM

[eroman, 2012-09-27 22:46:49]

Thanks for the review Jim!

Note that I made an additional change since you reviewed, PTAL.

[eroman, 2012-09-27 22:51:10]

Justin, could you review my changes to sandbox_types.h? Thanks!

[jschuh, 2012-09-27 22:55:02]

lgtm on the sandbox side

[jar (doing other things), 2012-09-28 02:04:19]

lgtm

[commit-bot: I haz the power, 2012-09-28 02:05:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/10981061/1002

[commit-bot: I haz the power, 2012-09-28 02:05:14]

Presubmit check for 10981061-1002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  sandbox/win/src/sandbox_types.h

Presubmit checks took 2.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-09-28 02:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/10981061/8002

[commit-bot: I haz the power, 2012-09-28 05:54:55]

Change committed as 159215

[rvargas (doing something else), 2012-09-28 18:12:12]

Just a question...

https://codereview.chromium.org/10981061/diff/8002/chrome/browser/metrics/met...
File chrome/browser/metrics/metrics_service.cc (right):

https://codereview.chromium.org/10981061/diff/8002/chrome/browser/metrics/met...
chrome/browser/metrics/metrics_service.cc:352: for (int i =
sandbox::SBOX_FATAL_INTEGRITY;
Does it matter that these values are numerically lower than the exception codes,
yet here they appear later on the array?

https://codereview.chromium.org/10981061/diff/8002/sandbox/win/src/sandbox_ty...
File sandbox/win/src/sandbox_types.h (right):

https://codereview.chromium.org/10981061/diff/8002/sandbox/win/src/sandbox_ty...
sandbox/win/src/sandbox_types.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
We were not supposed to touch dates anymore... yeah, I know some tool complains.

[eroman, 2012-09-28 19:28:29]

https://codereview.chromium.org/10981061/diff/8002/chrome/browser/metrics/met...
File chrome/browser/metrics/metrics_service.cc (right):

https://codereview.chromium.org/10981061/diff/8002/chrome/browser/metrics/met...
chrome/browser/metrics/metrics_service.cc:352: for (int i =
sandbox::SBOX_FATAL_INTEGRITY;
On 2012/09/28 18:12:12, rvargas wrote:
> Does it matter that these values are numerically lower than the exception
codes,
> yet here they appear later on the array?

It doesn't matter, since CustomHistogram internally sorts the range list. In
fact the kExceptionCodes[] isn't in sorted order either.

The good news is, once Kai lands support for sparse histograms, we can delete
all this code :)

https://codereview.chromium.org/10981061/diff/8002/sandbox/win/src/sandbox_ty...
File sandbox/win/src/sandbox_types.h (right):

https://codereview.chromium.org/10981061/diff/8002/sandbox/win/src/sandbox_ty...
sandbox/win/src/sandbox_types.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
On 2012/09/28 18:12:12, rvargas wrote:
> We were not supposed to touch dates anymore... yeah, I know some tool
complains.

Yeah, unfortunately the commit queue wouldn't let me land it without changing
this. I'll follow up with maruel and see if that was expected.