Add extra buckets to CrashExitCodes histogram for sandbox terminations

chrome/browser/metrics/metrics_service.cc

Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 8dc8dcff1087d123df9423b12dd2bcdc4e8283a6..293af4db8496be65c25bd994f34bd8cd2269b00a 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -215,6 +215,7 @@
 
 #if defined(OS_WIN)
 #include <windows.h>  // Needed for STATUS_* codes
+#include "sandbox/win/src/sandbox_types.h"  // For termination codes.
 #endif
 
 using base::Time;
@@ -346,6 +347,12 @@ std::vector<int> GetAllCrashExitCodes() {
 
   for (size_t i = 0; i < arraysize(kExceptionCodes); ++i)
     codes.push_back(MapCrashExitCodeForHistogram(kExceptionCodes[i]));
+
+  // Add the sandbox fatal termination codes.
+  for (int i = sandbox::SBOX_FATAL_INTEGRITY;

[rvargas (doing something else), 2012/09/28 18:12:12]

Does it matter that these values are numerically lower than the exception codes,
yet here they appear later on the array?

[eroman, 2012/09/28 19:28:29]

It doesn't matter, since CustomHistogram internally sorts the range list. In
fact the kExceptionCodes[] isn't in sorted order either.

The good news is, once Kai lands support for sparse histograms, we can delete
all this code :)

+       i <= sandbox::SBOX_FATAL_LAST; ++i) {
+    codes.push_back(MapCrashExitCodeForHistogram(i));
+  }
 #endif
 
   return codes;