Add extra buckets to CrashExitCodes histogram for sandbox terminations

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It
@@ skipping 197 matching lines @@
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/external_metrics.h"
 #include "chrome/browser/chromeos/system/statistics_provider.h"
 #endif
 
 #if defined(OS_WIN)
 #include <windows.h>  // Needed for STATUS_* codes
+#include "sandbox/win/src/sandbox_types.h"  // For termination codes.
 #endif
 
 using base::Time;
 using content::BrowserThread;
 using content::ChildProcessData;
 using content::LoadNotificationDetails;
 using content::PluginService;
 
 namespace {
 
@@ skipping 111 matching lines @@
     STATUS_IN_PAGE_ERROR,
     STATUS_NONCONTINUABLE_EXCEPTION,
     STATUS_NO_MEMORY,
     STATUS_PRIVILEGED_INSTRUCTION,
     STATUS_SINGLE_STEP,
     STATUS_STACK_OVERFLOW,
   };
 
   for (size_t i = 0; i < arraysize(kExceptionCodes); ++i)
     codes.push_back(MapCrashExitCodeForHistogram(kExceptionCodes[i]));
+
+  // Add the sandbox fatal termination codes.
+  for (int i = sandbox::SBOX_FATAL_INTEGRITY;

[rvargas (doing something else), 2012/09/28 18:12:12]

Does it matter that these values are numerically lower than the exception codes,
yet here they appear later on the array?

[eroman, 2012/09/28 19:28:29]

It doesn't matter, since CustomHistogram internally sorts the range list. In
fact the kExceptionCodes[] isn't in sorted order either.

The good news is, once Kai lands support for sparse histograms, we can delete
all this code :)

+       i <= sandbox::SBOX_FATAL_LAST; ++i) {
+    codes.push_back(MapCrashExitCodeForHistogram(i));
+  }
 #endif
 
   return codes;
 }
 
 }  // namespace
 
 // static
 MetricsService::ShutdownCleanliness MetricsService::clean_shutdown_status_ =
     MetricsService::CLEANLY_SHUTDOWN;
@@ skipping 1583 matching lines @@
   if (local_state) {
     const PrefService::Preference* uma_pref =
         local_state->FindPreference(prefs::kMetricsReportingEnabled);
     if (uma_pref) {
       bool success = uma_pref->GetValue()->GetAsBoolean(&result);
       DCHECK(success);
     }
   }
   return result;
 }