Issue 10963041: Revert "Revert 158067 - Remove native side of content_view_client"

Issue 10963041: Revert "Revert 158067 - Remove native side of content_view_client" (Closed)

Created:
8 years, 3 months ago by Yusuf

Modified:
8 years, 3 months ago

Reviewers:
jam, Yaron, Jay Civelli, mkosiba (inactive), willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, ctguil+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, zork+watch_chromium.org, cjhopman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Revert 158067 - Remove native side of content_view_client" The previous CL broke the build, because the changes in net_errors_java.template didn't get the net_error_java target to be rebuilt. We needed a net.gyp change that makes sure NetError.java gets recreated after the changes. BUG=137967 TBR=jam@chromium.org, mkosiba@chromium.org, willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158146

Patch Set 1 #

Patch Set 2 : Added the net.gyp fix that was needed to compile on android bots #

Patch Set 3 : Add additional_input_paths as a variable and input to java.gypi #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -514 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContentsClient.java	View		3 chunks	+31 lines, -4 lines	0 comments	Download
A	android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java	View		1 chunk	+143 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/java.gypi	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/android/browser_jni_registrar.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	content/browser/android/content_view_client.h	View		1 chunk	+0 lines, -101 lines	0 comments	Download
D	content/browser/android/content_view_client.cc	View		1 chunk	+0 lines, -240 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.h	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.cc	View		2 chunks	+19 lines, -4 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/content_jni.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View		1 chunk	+0 lines, -56 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		8 chunks	+13 lines, -13 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java	View		4 chunks	+10 lines, -2 lines	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/util/TestCallbackHelperContainer.java	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/util/TestContentViewClient.java	View		2 chunks	+0 lines, -36 lines	0 comments	Download
A +	content/public/android/javatests/src/org/chromium/content/browser/util/TestWebContentsObserver.java	View		3 chunks	+19 lines, -23 lines	0 comments	Download
M	net/android/java/net_errors_java.template	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download