Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

Issue 10963041: Revert "Revert 158067 - Remove native side of content_view_client" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add additional_input_paths as a variable and input to java.gypi Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
index af16d0a8188fbdc4a2c66df2a880c76f02018d76..c88229119c331fb1a431fc614a7d5b875ca7c878 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
@@ -15,8 +15,8 @@ import org.chromium.base.JNINamespace;
public abstract class WebContentsObserverAndroid {
private int mNativeWebContentsObserverAndroid;
- public WebContentsObserverAndroid(int webContentsPtr) {
- mNativeWebContentsObserverAndroid = nativeInit(webContentsPtr);
+ public WebContentsObserverAndroid(ContentViewCore contentViewCore) {
+ mNativeWebContentsObserverAndroid = nativeInit(contentViewCore.getNativeContentViewCore());
}
/**
@@ -47,6 +47,15 @@ public abstract class WebContentsObserverAndroid {
}
/**
+ * Called when the main frame of the page has committed.
+ * @param url The validated url for the page.
+ * @param baseUrl The validated base url for the page.
+ */
+ @CalledByNative
+ public void didNavigateMainFrame(String url, String baseUrl) {
+ }
+
+ /**
* Destroy the corresponding native object.
*/
@CalledByNative
@@ -57,6 +66,6 @@ public abstract class WebContentsObserverAndroid {
}
}
- private native int nativeInit(int webContentsPtr);
+ private native int nativeInit(int contentViewCorePtr);
private native void nativeDestroy(int nativeWebContentsObserverAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698