Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2822)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 10963041: Revert "Revert 158067 - Remove native side of content_view_client" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add additional_input_paths as a variable and input to java.gypi Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
index 5e761b8c325799f9795aa0f880423e926124b66d..2946fe1944357395674ec8fa0d298b58daeedca3 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
@@ -38,27 +38,18 @@ class TestAwContentsClient extends NullContentsClient {
return mOnEvaluateJavaScriptResultHelper;
}
- /**
- * ATTENTION!: When overriding the following methods, be sure to call
- * the corresponding methods in the super class. Otherwise
- * {@link CallbackHelper#waitForCallback()} methods will
- * stop working!
- */
@Override
public void onPageStarted(String url) {
- super.onPageStarted(url);
mOnPageStartedHelper.notifyCalled(url);
}
@Override
public void onPageFinished(String url) {
- super.onPageFinished(url);
mOnPageFinishedHelper.notifyCalled(url);
}
@Override
public void onReceivedError(int errorCode, String description, String failingUrl) {
- super.onReceivedError(errorCode, description, failingUrl);
mOnReceivedErrorHelper.notifyCalled(errorCode, description, failingUrl);
}

Powered by Google App Engine
This is Rietveld 408576698