Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 10938034: Eliminate box reordering in media::mp4::BoxReader. (Closed)

Created:
8 years, 3 months ago by strobe_
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Eliminate box reordering in media::mp4::BoxReader. ScanChildren() will reorder boxes based on their box type. The SampleDescription box is the only supported box which is agnostic about the box type of its children, and it is sensitive to the child order. This patch modifies ReadAllChildren() to read children in order without first invoking ScanChildren(). R=acolwell BUG= TEST=BoxReaderTest.ReadAllChildrenTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M media/mp4/box_definitions.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/mp4/box_reader.h View 2 chunks +14 lines, -12 lines 0 comments Download
M media/mp4/box_reader.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/mp4/box_reader_unittest.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
acolwell GONE FROM CHROMIUM
LGTM
8 years, 3 months ago (2012-09-21 16:41:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10938034/1
8 years, 3 months ago (2012-09-21 17:19:57 UTC) #2
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 19:34:29 UTC) #3
Change committed as 158046

Powered by Google App Engine
This is Rietveld 408576698