media/mp4/box_definitions.cc - Issue 10938034: Eliminate box reordering in media::mp4::BoxReader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/box_definitions.cc

Issue 10938034: Eliminate box reordering in media::mp4::BoxReader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/box_definitions.cc

diff --git a/media/mp4/box_definitions.cc b/media/mp4/box_definitions.cc

index 9b64f48b1594567f4642af20d153fe8fd1d4e13c..aa179e196ff80ccb1553b213ea0beafc101cb409 100644

--- a/media/mp4/box_definitions.cc

+++ b/media/mp4/box_definitions.cc

@@ -225,8 +225,7 @@ FourCC SampleDescription::BoxType() const { return FOURCC_STSD; }

bool SampleDescription::Parse(BoxReader* reader) {

uint32 count;

RCHECK(reader->SkipBytes(4) &&

- reader->Read4(&count) &&

- reader->ScanChildren());

+ reader->Read4(&count));

video_entries.clear();

audio_entries.clear();

« no previous file with comments | « no previous file | media/mp4/box_reader.h » ('j') | no next file with comments »