media/mp4/box_reader.cc - Issue 10938034: Eliminate box reordering in media::mp4::BoxReader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/box_reader.cc

Issue 10938034: Eliminate box reordering in media::mp4::BoxReader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/box_reader.cc

diff --git a/media/mp4/box_reader.cc b/media/mp4/box_reader.cc

index b352664a6ffe303ad3e337635ab9f061416b612d..1285ebfdb412297c17d95b67bf626a96ed28f81e 100644

--- a/media/mp4/box_reader.cc

+++ b/media/mp4/box_reader.cc

@@ -163,8 +163,6 @@ bool BoxReader::ScanChildren() {

scanned_ = true;

bool err = false;

- // TODO(strobe): Check or correct for multimap not inserting elements in

- // consistent order.

while (pos() < size()) {

BoxReader child(&buf_[pos_], size_ - pos_);

if (!child.ReadHeader(&err)) break;

« no previous file with comments | « media/mp4/box_reader.h ('k') | media/mp4/box_reader_unittest.cc » ('j') | no next file with comments »