Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 12183)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -1357,7 +1357,7 @@
void Assembler::LoadObject(Register dst, const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
movl(dst, Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsZoneHandle());
@@ -1369,7 +1369,7 @@
void Assembler::PushObject(const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
pushl(Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsZoneHandle());
@@ -1381,7 +1381,7 @@
void Assembler::CompareObject(Register reg, const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
cmpl(reg, Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsZoneHandle());
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698