Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: runtime/vm/assembler_ia32.cc

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/memory_region.h" 10 #include "vm/memory_region.h"
(...skipping 1339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1350 1350
1351 void Assembler::Drop(intptr_t stack_elements) { 1351 void Assembler::Drop(intptr_t stack_elements) {
1352 ASSERT(stack_elements >= 0); 1352 ASSERT(stack_elements >= 0);
1353 if (stack_elements > 0) { 1353 if (stack_elements > 0) {
1354 addl(ESP, Immediate(stack_elements * kWordSize)); 1354 addl(ESP, Immediate(stack_elements * kWordSize));
1355 } 1355 }
1356 } 1356 }
1357 1357
1358 1358
1359 void Assembler::LoadObject(Register dst, const Object& object) { 1359 void Assembler::LoadObject(Register dst, const Object& object) {
1360 if (object.IsSmi()) { 1360 if (object.IsSmi() || object.IsNull()) {
1361 movl(dst, Immediate(reinterpret_cast<int32_t>(object.raw()))); 1361 movl(dst, Immediate(reinterpret_cast<int32_t>(object.raw())));
1362 } else { 1362 } else {
1363 ASSERT(object.IsZoneHandle()); 1363 ASSERT(object.IsZoneHandle());
1364 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1364 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1365 EmitUint8(0xB8 + dst); 1365 EmitUint8(0xB8 + dst);
1366 buffer_.EmitObject(object); 1366 buffer_.EmitObject(object);
1367 } 1367 }
1368 } 1368 }
1369 1369
1370 1370
1371 void Assembler::PushObject(const Object& object) { 1371 void Assembler::PushObject(const Object& object) {
1372 if (object.IsSmi()) { 1372 if (object.IsSmi() || object.IsNull()) {
1373 pushl(Immediate(reinterpret_cast<int32_t>(object.raw()))); 1373 pushl(Immediate(reinterpret_cast<int32_t>(object.raw())));
1374 } else { 1374 } else {
1375 ASSERT(object.IsZoneHandle()); 1375 ASSERT(object.IsZoneHandle());
1376 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1376 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1377 EmitUint8(0x68); 1377 EmitUint8(0x68);
1378 buffer_.EmitObject(object); 1378 buffer_.EmitObject(object);
1379 } 1379 }
1380 } 1380 }
1381 1381
1382 1382
1383 void Assembler::CompareObject(Register reg, const Object& object) { 1383 void Assembler::CompareObject(Register reg, const Object& object) {
1384 if (object.IsSmi()) { 1384 if (object.IsSmi() || object.IsNull()) {
1385 cmpl(reg, Immediate(reinterpret_cast<int32_t>(object.raw()))); 1385 cmpl(reg, Immediate(reinterpret_cast<int32_t>(object.raw())));
1386 } else { 1386 } else {
1387 ASSERT(object.IsZoneHandle()); 1387 ASSERT(object.IsZoneHandle());
1388 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1388 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1389 if (reg == EAX) { 1389 if (reg == EAX) {
1390 EmitUint8(0x05 + (7 << 3)); 1390 EmitUint8(0x05 + (7 << 3));
1391 buffer_.EmitObject(object); 1391 buffer_.EmitObject(object);
1392 } else { 1392 } else {
1393 EmitUint8(0x81); 1393 EmitUint8(0x81);
1394 EmitOperand(7, Operand(reg)); 1394 EmitOperand(7, Operand(reg));
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1840 1840
1841 const char* Assembler::XmmRegisterName(XmmRegister reg) { 1841 const char* Assembler::XmmRegisterName(XmmRegister reg) {
1842 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 1842 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
1843 return xmm_reg_names[reg]; 1843 return xmm_reg_names[reg];
1844 } 1844 }
1845 1845
1846 1846
1847 } // namespace dart 1847 } // namespace dart
1848 1848
1849 #endif // defined TARGET_ARCH_IA32 1849 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698