Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 12183)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -1527,7 +1527,7 @@
void Assembler::LoadObject(Register dst, const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
ASSERT(object.IsZoneHandle());
@@ -1540,7 +1540,7 @@
void Assembler::StoreObject(const Address& dst, const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
LoadObject(TMP, object);
@@ -1550,7 +1550,7 @@
void Assembler::PushObject(const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
pushq(Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
LoadObject(TMP, object);
@@ -1560,7 +1560,7 @@
void Assembler::CompareObject(Register reg, const Object& object) {
- if (object.IsSmi()) {
+ if (object.IsSmi() || object.IsNull()) {
cmpq(reg, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
ASSERT(reg != TMP);

Powered by Google App Engine
This is Rietveld 408576698