Start the process of making Favicon into a Browser Component.

Start the process of making Favicon into a Browser Component.

This means, add the intended DEPS rules for a Browser Component
(depend on nothing within chrome/browser outside the component except
chrome/browser/api) and add a temporary owner for pure refactoring
changes so that such changes can be done more quickly. Larger changes
(that affect functionality or interfaces in non-refactoring ways) will
still be sent to a proper OWNER.

With the new DEPS, a presubmit check will warn developers that add new
temporarily-allowed (the files designated with a "!" rule in the DEPS
file).

BUG=146851
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157370

[Cait (Slow), 2012-09-07 15:25:24]

Hi Erik and Joi,

PTAL (especially at the DEPS file as I've never done one before). If all looks
good I'll send it on to the owner of favicon/.

Thanks,
Cait

[erikwright (departed), 2012-09-07 15:30:19]

Please also check which of the dependencies are test-only.

The easiest way is probably:

1) Generate the exceptions, store a copy in a temp file
2) Add the exceptions to DEPS with a regexp matching test files only
3) Generate the exceptions again, into a new temp file
4) The output of (3) is the general rule list. The diff between (1) and (3) is
the test rule list.

[Cait (Slow), 2012-09-07 15:39:35]

Thanks Erik,
I just checked and it looks like none of the dependencies are test-only.

[erikwright (departed), 2012-09-07 15:41:07]

LGTM.

[Jói, 2012-09-07 16:55:34]

LGTM

[Cait (Slow), 2012-09-10 19:54:02]

Friendly ping :)

[Cait (Slow), 2012-09-11 17:51:00]

stevejb: please review as OWNER of this directory. For more info about Browser
Components project see:
http://www.chromium.org/developers/design-documents/browser-components

Thanks!

[Cait (Slow), 2012-09-13 17:26:23]

ping: stevenjb (with the correct LDAP this time :) )

Please review as OWNER of this directory. For more info about Browser
Components project see:
http://www.chromium.org/developers/design-documents/browser-components

Thanks!

[stevenjb, 2012-09-17 16:34:02]

Was on vacation, just got back. lgtm.

[commit-bot: I haz the power, 2012-09-17 16:56:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/10928053/2003

[commit-bot: I haz the power, 2012-09-17 17:14:05]

Retried try job too often for step(s) compile

[commit-bot: I haz the power, 2012-09-17 21:44:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/10928053/5004

[commit-bot: I haz the power, 2012-09-17 21:59:35]

Retried try job too often for step(s) interactive_ui_tests, jingle_unittests,
gpu_unittests, base_unittests, sync_integration_tests, sql_unittests,
chrome_frame_unittests, content_unittests, safe_browsing_tests, ipc_tests,
mini_installer_test, cacheinvalidation_unittests, remoting_unittests,
browser_tests, net_unittests, installer_util_unittests, chrome_frame_net_tests,
check_deps, crypto_unittests, unit_tests, nacl_integration, media_unittests,
content_browsertests, printing_unittests, sync_unit_tests

[commit-bot: I haz the power, 2012-09-18 14:07:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/10928053/5004

[commit-bot: I haz the power, 2012-09-18 17:02:30]

Change committed as 157370