Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: chrome/browser/favicon/DEPS

Issue 10928053: Start the process of making Favicon into a Browser Component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WATCHLISTS ('k') | chrome/browser/favicon/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/DEPS
diff --git a/chrome/browser/favicon/DEPS b/chrome/browser/favicon/DEPS
new file mode 100644
index 0000000000000000000000000000000000000000..7a7f2caa197f312ea504ce0d05701b9c2b16e94d
--- /dev/null
+++ b/chrome/browser/favicon/DEPS
@@ -0,0 +1,33 @@
+include_rules = [
+ # Favicon is being made into a Browser Component, so we have these
+ # three basic rules followed by temporary exceptions. Please don't
+ # add to the list of exceptions!
+ "-chrome/browser",
+ "+chrome/browser/api",
+ "+chrome/browser/favicon",
+
+ # Permanently-allowed DEPS beyond the standard Browser
+ # Components-like DEPS above go here.
+ "+third_party/skia/include/core/SkBitmap.h", # For phone number i18n.
+
+ # TODO(caitkp): Bring this list to zero.
+ #
+ # Do not add to the list of temporarily-allowed dependencies below,
+ # and please do not introduce more #includes of these files.
+ "!chrome/browser/bookmarks/bookmark_model.h",
+ "!chrome/browser/bookmarks/bookmark_model_factory.h",
+ "!chrome/browser/cancelable_request.h",
+ "!chrome/browser/history/history.h",
+ "!chrome/browser/history/history_backend.h",
+ "!chrome/browser/history/history_service_factory.h",
+ "!chrome/browser/history/history_types.h",
+ "!chrome/browser/history/select_favicon_frames.h",
+ "!chrome/browser/prefs/pref_service.h",
+ "!chrome/browser/profiles/profile.h",
+ "!chrome/browser/profiles/profile_dependency_manager.h",
+ "!chrome/browser/profiles/profile_keyed_service.h",
+ "!chrome/browser/profiles/profile_keyed_service_factory.h",
+ "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",
+ # Do not add to the list of temporarily-allowed dependencies above,
+ # and please do not introduce more #includes of these files.
+]
« no previous file with comments | « WATCHLISTS ('k') | chrome/browser/favicon/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698