chrome/browser/favicon/DEPS - Issue 10928053: Start the process of making Favicon into a Browser Component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 10928053: Start the process of making Favicon into a Browser Component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 # Favicon is being made into a Browser Component, so we have these

	3 # three basic rules followed by temporary exceptions. Please don't

	4 # add to the list of exceptions!

	5 "-chrome/browser",

	6 "+chrome/browser/api",

	7 "+chrome/browser/favicon",

	8

	9 # Permanently-allowed DEPS beyond the standard Browser

	10 # Components-like DEPS above go here.

	11 "+third_party/skia/include/core/SkBitmap.h", # For phone number i18n.

	12

	13 # TODO(caitkp): Bring this list to zero.

	14 #

	15 # Do not add to the list of temporarily-allowed dependencies below,

	16 # and please do not introduce more #includes of these files.

	17 "!chrome/browser/bookmarks/bookmark_model.h",

	18 "!chrome/browser/bookmarks/bookmark_model_factory.h",

	19 "!chrome/browser/cancelable_request.h",

	20 "!chrome/browser/history/history.h",

	21 "!chrome/browser/history/history_backend.h",

	22 "!chrome/browser/history/history_service_factory.h",

	23 "!chrome/browser/history/history_types.h",

	24 "!chrome/browser/history/select_favicon_frames.h",

	25 "!chrome/browser/prefs/pref_service.h",

	26 "!chrome/browser/profiles/profile.h",

	27 "!chrome/browser/profiles/profile_dependency_manager.h",

	28 "!chrome/browser/profiles/profile_keyed_service.h",

	29 "!chrome/browser/profiles/profile_keyed_service_factory.h",

	30 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",

	31 # Do not add to the list of temporarily-allowed dependencies above,

	32 # and please do not introduce more #includes of these files.

	33 ]

OLD	NEW

« no previous file with comments | « WATCHLISTS ('k') | chrome/browser/favicon/OWNERS » ('j') | no next file with comments »