Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7252)

Unified Diff: chrome/browser/ui/panels/detached_panel_browsertest.cc

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: avoid panel_create_mode being unused_var in Ash Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/detached_panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/detached_panel_browsertest.cc b/chrome/browser/ui/panels/detached_panel_browsertest.cc
index cc4858e8f31260c52442761496c4553e2ef604c3..fa43795ceba612e3e5525626c6d48d8a8796adf0 100644
--- a/chrome/browser/ui/panels/detached_panel_browsertest.cc
+++ b/chrome/browser/ui/panels/detached_panel_browsertest.cc
@@ -16,13 +16,19 @@ IN_PROC_BROWSER_TEST_F(DetachedPanelBrowserTest, CheckDetachedPanelProperties) {
PanelManager* panel_manager = PanelManager::GetInstance();
DetachedPanelStrip* detached_strip = panel_manager->detached_strip();
- Panel* panel = CreateDetachedPanel("1", gfx::Rect(300, 200, 250, 200));
+ // Create an initially detached panel (as opposed to other tests which create
+ // a docked panel, then detaches it).
+ gfx::Rect bounds(300, 200, 250, 200);
+ CreatePanelParams params("1", bounds, SHOW_AS_ACTIVE);
+ params.create_mode = PanelManager::CREATE_AS_DETACHED;
+ Panel* panel = CreatePanelWithParams(params);
scoped_ptr<NativePanelTesting> panel_testing(
CreateNativePanelTesting(panel));
EXPECT_EQ(1, panel_manager->num_panels());
EXPECT_TRUE(detached_strip->HasPanel(panel));
+ EXPECT_EQ(bounds, panel->GetBounds());
EXPECT_FALSE(panel->always_on_top());
EXPECT_TRUE(panel_testing->IsButtonVisible(panel::CLOSE_BUTTON));
« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/panels/detached_panel_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698