Allow panels to be created as detached panels.

chrome/browser/ui/panels/detached_panel_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/detached_panel_strip.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 
 class DetachedPanelBrowserTest : public BasePanelBrowserTest {
 };
 
 IN_PROC_BROWSER_TEST_F(DetachedPanelBrowserTest, CheckDetachedPanelProperties) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   DetachedPanelStrip* detached_strip = panel_manager->detached_strip();
 
-  Panel* panel = CreateDetachedPanel("1", gfx::Rect(300, 200, 250, 200));
+  // Create an initially detached panel (as opposed to other tests which create
+  // a docked panel, then detaches it).
+  gfx::Rect bounds(300, 200, 250, 200);
+  CreatePanelParams params("1", bounds, SHOW_AS_ACTIVE);
+  params.create_mode = PanelManager::CREATE_AS_DETACHED;
+  Panel* panel = CreatePanelWithParams(params);
   scoped_ptr<NativePanelTesting> panel_testing(
       CreateNativePanelTesting(panel));
 
   EXPECT_EQ(1, panel_manager->num_panels());
   EXPECT_TRUE(detached_strip->HasPanel(panel));
 
+  EXPECT_EQ(bounds, panel->GetBounds());
   EXPECT_FALSE(panel->always_on_top());
 
   EXPECT_TRUE(panel_testing->IsButtonVisible(panel::CLOSE_BUTTON));
   EXPECT_FALSE(panel_testing->IsButtonVisible(panel::MINIMIZE_BUTTON));
   EXPECT_FALSE(panel_testing->IsButtonVisible(panel::RESTORE_BUTTON));
 
   EXPECT_EQ(panel::RESIZABLE_ALL_SIDES, panel->CanResizeByMouse());
 
   Panel::AttentionMode expected_attention_mode =
       static_cast<Panel::AttentionMode>(Panel::USE_PANEL_ATTENTION |
@@ skipping 106 matching lines @@
   WaitForPanelActiveState(panel, SHOW_AS_INACTIVE);
 
   // Clicking on an inactive detached panel's titlebar activates it.
   test_panel->PressLeftMouseButtonTitlebar(panel->GetBounds().origin());
   test_panel->ReleaseMouseButtonTitlebar();
   WaitForPanelActiveState(panel, SHOW_AS_ACTIVE);
   EXPECT_FALSE(panel->IsMinimized());
 
   panel_manager->CloseAll();
 }