Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.cc

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: avoid panel_create_mode being unused_var in Ash Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/base_panel_browser_test.cc
diff --git a/chrome/browser/ui/panels/base_panel_browser_test.cc b/chrome/browser/ui/panels/base_panel_browser_test.cc
index 2aae3555ccd253be1572d221efada726b5af8c23..d127f7b23ab53d61698d4d84119173205be98793 100644
--- a/chrome/browser/ui/panels/base_panel_browser_test.cc
+++ b/chrome/browser/ui/panels/base_panel_browser_test.cc
@@ -15,8 +15,8 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/panels/native_panel.h"
-#include "chrome/browser/ui/panels/panel_manager.h"
#include "chrome/browser/ui/panels/panel_mouse_watcher.h"
+#include "chrome/browser/ui/panels/panel_strip.h"
#include "chrome/browser/ui/panels/test_panel_active_state_observer.h"
#include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
#include "chrome/browser/ui/tab_contents/tab_contents.h"
@@ -291,7 +291,8 @@ BasePanelBrowserTest::CreatePanelParams::CreatePanelParams(
bounds(bounds),
show_flag(show_flag),
wait_for_fully_created(true),
- expected_active_state(show_flag) {
+ expected_active_state(show_flag),
+ create_mode(PanelManager::CREATE_AS_DOCKED) {
}
Panel* BasePanelBrowserTest::CreatePanelWithParams(
@@ -312,7 +313,8 @@ Panel* BasePanelBrowserTest::CreatePanelWithParams(
PanelManager* manager = PanelManager::GetInstance();
Panel* panel = manager->CreatePanel(params.name, browser()->profile(),
- params.url, params.bounds.size());
+ params.url, params.bounds,
+ params.create_mode);
if (!params.url.is_empty())
observer.Wait();
« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.h ('k') | chrome/browser/ui/panels/detached_panel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698