runtime/vm/object.h - Issue 10918010: Fix for issue 4848 (Added missing store buffer updates when storing an object reference into anothe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 10918010: Fix for issue 4848 (Added missing store buffer updates when storing an object reference into anothe… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 11629)

+++ runtime/vm/object.h (working copy)

@@ -2673,6 +2673,8 @@

static const intptr_t kEntrySize = sizeof(int32_t); // NOLINT

void set_instructions(RawInstructions* instructions) {

+ // RawInstructions are never allocated in New space and hence a

+ // store buffer update is not needed here.

raw_ptr()->instructions_ = instructions;

}

void set_pointer_offsets_length(intptr_t value) {

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »