Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: runtime/vm/object.h

Issue 10918010: Fix for issue 4848 (Added missing store buffer updates when storing an object reference into anothe… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OBJECT_H_ 5 #ifndef VM_OBJECT_H_
6 #define VM_OBJECT_H_ 6 #define VM_OBJECT_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/utils.h" 10 #include "platform/utils.h"
(...skipping 2655 matching lines...) Expand 10 before | Expand all | Expand 10 after
2666 2666
2667 private: 2667 private:
2668 const uword pc_; 2668 const uword pc_;
2669 2669
2670 DISALLOW_COPY_AND_ASSIGN(FindRawCodeVisitor); 2670 DISALLOW_COPY_AND_ASSIGN(FindRawCodeVisitor);
2671 }; 2671 };
2672 2672
2673 static const intptr_t kEntrySize = sizeof(int32_t); // NOLINT 2673 static const intptr_t kEntrySize = sizeof(int32_t); // NOLINT
2674 2674
2675 void set_instructions(RawInstructions* instructions) { 2675 void set_instructions(RawInstructions* instructions) {
2676 // RawInstructions are never allocated in New space and hence a
2677 // store buffer update is not needed here.
2676 raw_ptr()->instructions_ = instructions; 2678 raw_ptr()->instructions_ = instructions;
2677 } 2679 }
2678 void set_pointer_offsets_length(intptr_t value) { 2680 void set_pointer_offsets_length(intptr_t value) {
2679 ASSERT(value >= 0); 2681 ASSERT(value >= 0);
2680 raw_ptr()->pointer_offsets_length_ = value; 2682 raw_ptr()->pointer_offsets_length_ = value;
2681 } 2683 }
2682 int32_t* PointerOffsetAddrAt(int index) const { 2684 int32_t* PointerOffsetAddrAt(int index) const {
2683 ASSERT(index >= 0); 2685 ASSERT(index >= 0);
2684 ASSERT(index < pointer_offsets_length()); 2686 ASSERT(index < pointer_offsets_length());
2685 // TODO(iposva): Unit test is missing for this functionality. 2687 // TODO(iposva): Unit test is missing for this functionality.
(...skipping 2859 matching lines...) Expand 10 before | Expand all | Expand 10 after
5545 if (this->CharAt(i) != str.CharAt(begin_index + i)) { 5547 if (this->CharAt(i) != str.CharAt(begin_index + i)) {
5546 return false; 5548 return false;
5547 } 5549 }
5548 } 5550 }
5549 return true; 5551 return true;
5550 } 5552 }
5551 5553
5552 } // namespace dart 5554 } // namespace dart
5553 5555
5554 #endif // VM_OBJECT_H_ 5556 #endif // VM_OBJECT_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698