Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: runtime/vm/object.cc

Issue 10918010: Fix for issue 4848 (Added missing store buffer updates when storing an object reference into anothe… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 11629)
+++ runtime/vm/object.cc (working copy)
@@ -3465,8 +3465,7 @@
void TypeArguments::SetTypeAt(intptr_t index, const AbstractType& value) const {
ASSERT(!IsCanonical());
- // TODO(iposva): Add storing NoGCScope.
- *TypeAddr(index) = value.raw();
+ StorePointer(TypeAddr(index), value.raw());
}
@@ -7449,7 +7448,7 @@
void ContextScope::SetNameAt(intptr_t scope_index, const String& name) const {
- VariableDescAddr(scope_index)->name = name.raw();
+ StorePointer(&(VariableDescAddr(scope_index)->name), name.raw());
}
@@ -7470,7 +7469,7 @@
void ContextScope::SetTypeAt(
intptr_t scope_index, const AbstractType& type) const {
- VariableDescAddr(scope_index)->type = type.raw();
+ StorePointer(&(VariableDescAddr(scope_index)->type), type.raw());
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698