Switch Extensions::TabHelper to use WebContents, WebContentsUserData.

Switch Extensions::TabHelper to use WebContents, WebContentsUserData.

BUG=107201
TEST=no visible change
TBR=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155743

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=155901

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156366

[Aaron Boodman, 2012-09-04 21:33:40]

If it fits, it ships. LGTM.

[commit-bot: I haz the power, 2012-09-05 14:16:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917026/1

[commit-bot: I haz the power, 2012-09-05 14:17:04]

Failed to apply patch for chrome/browser/sessions/session_service.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/sessions/session_service.cc
Hunk #1 FAILED at 609.
Hunk #2 FAILED at 716.
Hunk #3 succeeded at 1304 (offset -13 lines).
2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/sessions/session_service.cc.rej

[commit-bot: I haz the power, 2012-09-05 15:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917026/6004

[commit-bot: I haz the power, 2012-09-05 15:16:33]

Presubmit check for 10917026-6004 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/sessions
    chrome/browser/ui/gtk
    chrome/browser/sync
    chrome/browser/ui/ash/launcher
    chrome/browser/ui/sync
    chrome/browser/ui/views/tabs
    chrome/browser/ui/tabs
    chrome/browser/ui
    chrome/browser/ui/views

Presubmit checks took 3.4s to calculate.

[Avi (use Gerrit), 2012-09-05 17:04:28]

Unit tests fail.

Duplicate a tab > WebContentsObserver notification > TabHelper clones self on
new WebContents > various other pieces die because there is no TabContents yet.

This cannot land until ScriptBadgeController and PageActionController move off
of TabContents. Will make a new CL for them.

[commit-bot: I haz the power, 2012-09-08 05:35:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917026/9097

[commit-bot: I haz the power, 2012-09-08 05:35:25]

Presubmit check for 10917026-9097 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/sessions
    chrome/browser/ui/gtk
    chrome/browser/sync
    chrome/browser/ui/ash/launcher
    chrome/browser/ui/sync
    chrome/browser/ui/views/tabs
    chrome/browser/ui/tabs
    chrome/browser/ui
    chrome/browser/ui/views

Presubmit checks took 3.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Avi (use Gerrit), 2012-09-10 13:54:37]

Ben for sweeping OWNERS rights.

[commit-bot: I haz the power, 2012-09-10 13:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917026/2054

[Ben Goodger (Google), 2012-09-10 15:38:12]

hotness.

lgtm

[commit-bot: I haz the power, 2012-09-10 16:16:43]

Change committed as 155743

[Avi (use Gerrit), 2012-09-11 23:57:44]

Trying again. The one change here is that when an extensions tabhelper is
created, it forces the creation (if one doesn't exist) of a sessions tab helper
since it relies on it.

PTAL.

[Ben Goodger (Google), 2012-09-12 18:39:00]

lgtm

[commit-bot: I haz the power, 2012-09-12 18:54:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917026/9148

[commit-bot: I haz the power, 2012-09-12 19:36:06]

Try job failure for 10917026-9148 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...