chrome/browser/extensions/api/omnibox/omnibox_api.cc - Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase only Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

index 85b352b28d5bc7e95beff5c5af9e933a2be00faf..efe9f07ee07601b8e5f12dc1bf8eda7781ca9c25 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

@@ -84,8 +84,8 @@ void ExtensionOmniboxEventRouter::OnInputEntered(

ExtensionSystem::Get(profile)->extension_service()->extensions()->

GetByID(extension_id);

CHECK(extension);

- tab_contents->extension_tab_helper()->active_tab_permission_manager()->

- GrantIfRequested(extension);

+ extensions::TabHelper::FromWebContents(tab_contents->web_contents())->

+ active_tab_permission_manager()->GrantIfRequested(extension);

scoped_ptr<ListValue> args(new ListValue());

args->Set(0, Value::CreateStringValue(input));