chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase only Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index 7a82d3737ace73683d8babe8ea07465c49af9d8d..d51d48af4c2e3aed4772b97ea88d2d89f3ed22f2 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -526,7 +526,7 @@ void BrowserTabStripController::SetTabRendererDataFromModel(

data->show_icon = tab_contents->favicon_tab_helper()->ShouldDisplayFavicon();

data->mini = model_->IsMiniTab(model_index);

data->blocked = model_->IsTabBlocked(model_index);

- data->app = tab_contents->extension_tab_helper()->is_app();

+ data->app = extensions::TabHelper::FromWebContents(contents)->is_app();

data->mode = browser_->search_model()->mode().mode;

// Get current gradient background animation to paint.

data->gradient_background_opacity = browser_->search_delegate()->