[Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend}

[Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend}

Combine OnNotifications{Enabled,Disabled}() into OnInvalidatorStateChange().  Replace NotificationsDisabledReason with InvalidatorState.

Rename OnIncomingNotification to OnIncomingInvalidation.  Also change
some references of "notification" to "invalidation".

Set the initial invalidator state in ChromeToMobileService.  Also remove OnNotificationsEnabled() call from OnIncomingInvalidation().

Instantiate InvalidatorTest template for ProfileSyncService.

Move comments for invalidation-related functions from ProfileSyncService to InvalidatorFrontend.

Put DISALLOW_COPY_AND_ASSIGN on some classes.

Fix comment in invalidator.h.

BUG=142475
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155448

[akalin, 2012-09-06 00:00:11]

rlarocque is the lucky winner! (+rlarocque for sync/ and c/b/sync review)

+msw for chrome_to_mobile stuff
+dcheng for push_messaging stuff (no OWNERS for that dir, though?)

[dcheng, 2012-09-06 00:07:19]

c/b/e/push_messaging LGTM.

[msw, 2012-09-06 00:43:48]

c/b/chrome_to_mobile_service.[h|cc] LGTM with a nit.

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/chrome_to_mo...
File chrome/browser/chrome_to_mobile_service.cc (right):

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/chrome_to_mo...
chrome/browser/chrome_to_mobile_service.cc:187: sync_invalidation_enabled_ =
nit: move above the "Register for cloud..." comment.

[rlarocque, 2012-09-06 17:50:34]

LGTM.

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/sync/glue/sy...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/sync/glue/sy...
chrome/browser/sync/glue/sync_backend_host.cc:1087: #if defined(OS_ANDROID)
:(

I'm guessing there's no easy alternative to this.

[akalin, 2012-09-06 20:30:10]

Committing soon

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/chrome_to_mo...
File chrome/browser/chrome_to_mobile_service.cc (right):

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/chrome_to_mo...
chrome/browser/chrome_to_mobile_service.cc:187: sync_invalidation_enabled_ =
On 2012/09/06 00:43:48, msw wrote:
> nit: move above the "Register for cloud..." comment.

Done.

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/sync/glue/sy...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/10916131/diff/2001/chrome/browser/sync/glue/sy...
chrome/browser/sync/glue/sync_backend_host.cc:1087: #if defined(OS_ANDROID)
On 2012/09/06 17:50:34, rlarocque wrote:
> :(
> 
> I'm guessing there's no easy alternative to this.

Couldn't think of one.  I'm a bit wary of setting the default to
NOTIFICATIONS_ENABLED for all platforms. :/

[commit-bot: I haz the power, 2012-09-06 20:31:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10916131/3004

[commit-bot: I haz the power, 2012-09-06 20:31:46]

Presubmit check for 10916131-3004 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:42
    bool IsHandlerRegisteredForTest(syncer::InvalidationHandler* handler) const;
\
  chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:43
    syncer::ObjectIdSet GetRegisteredIdsForTest( \
  chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:115
    return invalidator_registrar_->IsHandlerRegisteredForTest(handler); \
  chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:174
    return core_->IsHandlerRegisteredForTest(handler); \
  chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:180
    return core_->GetRegisteredIdsForTest(handler); \
  sync/notifier/fake_invalidator.cc:13
    return registrar_.IsHandlerRegisteredForTest(handler); \
  sync/notifier/invalidator_state.cc:39
    notifier::NotificationsDisabledReason ToNotifierReasonForTest(

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/extensions

Presubmit checks took 3.9s to calculate.

[akalin, 2012-09-06 20:42:59]

+brettw for chrome/ OWNERS
+yoz for c/b/extensions OWNERS

although chrome_to_mobile probably should have its own owners.

[Yoyo Zhou, 2012-09-06 21:08:30]

rubber-stamp LGTM

[akalin, 2012-09-06 23:45:10]

TBRing brettw since it just needs a rubberstamp anyway.

[commit-bot: I haz the power, 2012-09-06 23:45:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10916131/7003

[commit-bot: I haz the power, 2012-09-07 04:31:33]

Try job failure for 10916131-7003 (retry) on win_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-09-07 04:33:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10916131/7003

[commit-bot: I haz the power, 2012-09-07 06:26:56]

Try job failure for 10916131-7003 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-09-07 08:34:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10916131/7003

[commit-bot: I haz the power, 2012-09-07 10:41:09]

Try job failure for 10916131-7003 (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, steps "sync_integration_tests,
interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-09-07 17:14:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10916131/7003

[commit-bot: I haz the power, 2012-09-07 17:31:55]

Try job failure for 10916131-7003 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...