Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2299)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 10916131: [Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/invalidation_frontend.h ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index a09766bf8e220e73f7a8a1f7de199081690630a2..c998389b663280b0785a2041fd98338f15a10d7b 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -259,12 +259,11 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
virtual void SetSyncSetupCompleted();
// syncer::InvalidationHandler implementation (via SyncFrontend).
- virtual void OnNotificationsEnabled() OVERRIDE;
- virtual void OnNotificationsDisabled(
- syncer::NotificationsDisabledReason reason) OVERRIDE;
- virtual void OnIncomingNotification(
+ virtual void OnInvalidatorStateChange(
+ syncer::InvalidatorState state) OVERRIDE;
+ virtual void OnIncomingInvalidation(
const syncer::ObjectIdStateMap& id_state_map,
- syncer::IncomingNotificationSource source) OVERRIDE;
+ syncer::IncomingInvalidationSource source) OVERRIDE;
// SyncFrontend implementation.
virtual void OnBackendInitialized(
@@ -563,58 +562,15 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
// been cleared yet. Virtual for testing purposes.
virtual bool waiting_for_auth() const;
- // Invalidation clients should follow the pattern below:
- //
- // When starting the client:
- //
- // pss->RegisterInvalidationHandler(client_handler);
- //
- // When the set of IDs to register changes for the client during its lifetime
- // (i.e., between calls to RegisterInvalidationHandler(client_handler) and
- // UnregisterInvalidationHandler(client_handler):
- //
- // pss->UpdateRegisteredInvalidationIds(client_handler, client_ids);
- //
- // When shutting down the client for browser shutdown:
- //
- // pss->UnregisterInvalidationHandler(client_handler);
- //
- // Note that there's no call to UpdateRegisteredIds() -- this is because the
- // invalidation API persists registrations across browser restarts.
- //
- // When permanently shutting down the client, e.g. when disabling the related
- // feature:
- //
- // pss->UpdateRegisteredInvalidationIds(client_handler, ObjectIdSet());
- // pss->UnregisterInvalidationHandler(client_handler);
-
- // NOTE(akalin): Invalidations that come in during browser shutdown may get
- // dropped. This won't matter once we have an Acknowledge API, though: see
- // http://crbug.com/78462 and http://crbug.com/124149.
-
- // Starts sending notifications to |handler|. |handler| must not be NULL,
- // and it must already be registered.
- //
- // Handler registrations are persisted across restarts of sync.
+ // InvalidationFrontend implementation.
virtual void RegisterInvalidationHandler(
syncer::InvalidationHandler* handler) OVERRIDE;
-
- // Updates the set of ObjectIds associated with |handler|. |handler| must
- // not be NULL, and must already be registered. An ID must be registered for
- // at most one handler.
- //
- // Registered IDs are persisted across restarts of sync.
virtual void UpdateRegisteredInvalidationIds(
syncer::InvalidationHandler* handler,
const syncer::ObjectIdSet& ids) OVERRIDE;
-
- // Stops sending notifications to |handler|. |handler| must not be NULL, and
- // it must already be registered. Note that this doesn't unregister the IDs
- // associated with |handler|.
- //
- // Handler registrations are persisted across restarts of sync.
virtual void UnregisterInvalidationHandler(
syncer::InvalidationHandler* handler) OVERRIDE;
+ virtual syncer::InvalidatorState GetInvalidatorState() const OVERRIDE;
// ProfileKeyedService implementation.
virtual void Shutdown() OVERRIDE;
« no previous file with comments | « chrome/browser/sync/invalidation_frontend.h ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698