Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 10916131: [Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | sync/internal_api/test/fake_sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index 9f5538eb7d51d6be0fe8155178ae800d2e49d85d..d2ffa6ce79efda6c866f22cd3d0e2c5000fd01b2 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -906,24 +906,18 @@ class SyncManagerTest : public testing::Test,
GetEncryptedTypes(trans->GetWrappedTrans());
}
- void SimulateEnableNotificationsForTest() {
+ void SimulateInvalidatorStateChangeForTest(InvalidatorState state) {
DCHECK(sync_manager_.thread_checker_.CalledOnValidThread());
- sync_manager_.OnNotificationsEnabled();
- }
-
- void SimulateDisableNotificationsForTest(
- NotificationsDisabledReason reason) {
- DCHECK(sync_manager_.thread_checker_.CalledOnValidThread());
- sync_manager_.OnNotificationsDisabled(reason);
+ sync_manager_.OnInvalidatorStateChange(state);
}
void TriggerOnIncomingNotificationForTest(ModelTypeSet model_types) {
DCHECK(sync_manager_.thread_checker_.CalledOnValidThread());
ModelTypeStateMap type_state_map =
ModelTypeSetToStateMap(model_types, std::string());
- sync_manager_.OnIncomingNotification(
+ sync_manager_.OnIncomingInvalidation(
ModelTypeStateMapToObjectIdStateMap(type_state_map),
- REMOTE_NOTIFICATION);
+ REMOTE_INVALIDATION);
}
void SetProgressMarkerForType(ModelType type, bool set) {
@@ -996,7 +990,7 @@ TEST_F(SyncManagerTest, ProcessJsMessage) {
ListValue disabled_args;
disabled_args.Append(
- Value::CreateStringValue("TRANSIENT_NOTIFICATION_ERROR"));
+ Value::CreateStringValue("TRANSIENT_INVALIDATION_ERROR"));
EXPECT_CALL(reply_handler,
HandleJsReply("getNotificationState",
@@ -1284,9 +1278,9 @@ TEST_F(SyncManagerTest, OnNotificationStateChange) {
StrictMock<MockJsEventHandler> event_handler;
DictionaryValue enabled_details;
- enabled_details.SetString("state", "NO_NOTIFICATION_ERROR");
+ enabled_details.SetString("state", "INVALIDATIONS_ENABLED");
DictionaryValue disabled_details;
- disabled_details.SetString("state", "TRANSIENT_NOTIFICATION_ERROR");
+ disabled_details.SetString("state", "TRANSIENT_INVALIDATION_ERROR");
EXPECT_CALL(event_handler,
HandleJsEvent("onNotificationStateChange",
@@ -1295,16 +1289,16 @@ TEST_F(SyncManagerTest, OnNotificationStateChange) {
HandleJsEvent("onNotificationStateChange",
HasDetailsAsDictionary(disabled_details)));
- SimulateEnableNotificationsForTest();
- SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
+ SimulateInvalidatorStateChangeForTest(INVALIDATIONS_ENABLED);
+ SimulateInvalidatorStateChangeForTest(TRANSIENT_INVALIDATION_ERROR);
SetJsEventHandler(event_handler.AsWeakHandle());
- SimulateEnableNotificationsForTest();
- SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
+ SimulateInvalidatorStateChangeForTest(INVALIDATIONS_ENABLED);
+ SimulateInvalidatorStateChangeForTest(TRANSIENT_INVALIDATION_ERROR);
SetJsEventHandler(WeakHandle<JsEventHandler>());
- SimulateEnableNotificationsForTest();
- SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
+ SimulateInvalidatorStateChangeForTest(INVALIDATIONS_ENABLED);
+ SimulateInvalidatorStateChangeForTest(TRANSIENT_INVALIDATION_ERROR);
// Should trigger the replies.
PumpLoop();
@@ -1322,7 +1316,7 @@ TEST_F(SyncManagerTest, OnIncomingNotification) {
DictionaryValue expected_details;
{
ListValue* model_type_list = new ListValue();
- expected_details.SetString("source", "REMOTE_NOTIFICATION");
+ expected_details.SetString("source", "REMOTE_INVALIDATION");
expected_details.Set("changedTypes", model_type_list);
for (ModelTypeSet::Iterator it = model_types.First();
it.Good(); it.Inc()) {
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | sync/internal_api/test/fake_sync_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698